[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2023072737-resort-dwelled-8cb9@gregkh>
Date: Thu, 27 Jul 2023 09:59:25 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Tree Davies <tdavies@...kphysics.net>
Cc: philipp.g.hortmann@...il.com, dan.carpenter@...aro.org,
linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v3] staging: rtl8192e: Rename function IsHTHalfNmodeAPs
to is_ht_half_nmode_aps
On Mon, Jun 26, 2023 at 11:12:46PM -0700, Tree Davies wrote:
> Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_aps in order to
> fix checkpatch warning: Avoid CamelCase
>
> Signed-off-by: Tree Davies <tdavies@...kphysics.net>
> ---
> v3: Fix email parch as v2 info was placed above the ---
> v2: Rename is_ht_half_nmode_a_ps -> is_ht_half_nmode_aps
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index f9fa3f2bb728..d09342dde61d 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -139,7 +139,7 @@ u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate)
> return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf];
> }
>
> -bool IsHTHalfNmodeAPs(struct rtllib_device *ieee)
> +bool is_ht_half_nmode_aps(struct rtllib_device *ieee)
As this is a global symbol, can you please prefix it with the driver
name so that the global symbol table looks semi-sane?
Perhaps rtllib_is_ht_half_nmode_aps()?
thanks,
greg k-h
Powered by blists - more mailing lists