linux-kernel - Re: [RFC PATCH v2 10/10] rust: puzzlefs: add oci_root_dir and image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANeycqrGTB3Pd1JBoYHgLHU=ckBQjdv1oZt+no31aZ5UXHW8uA@mail.gmail.com>
Date:   Thu, 27 Jul 2023 05:06:32 -0300
From:   Wedson Almeida Filho <wedsonaf@...il.com>
To:     Trevor Gross <tmgross@...ch.edu>
Cc:     Ariel Miculas <amiculas@...co.com>, rust-for-linux@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        tycho@...ho.pizza, brauner@...nel.org, viro@...iv.linux.org.uk,
        ojeda@...nel.org, alex.gaynor@...il.com
Subject: Re: [RFC PATCH v2 10/10] rust: puzzlefs: add oci_root_dir and
 image_manifest filesystem parameters

On Wed, 26 Jul 2023 at 21:02, Trevor Gross <tmgross@...ch.edu> wrote:
>
> On Wed, Jul 26, 2023 at 7:48 PM Wedson Almeida Filho <wedsonaf@...il.com> wrote:
> >
> > On Wed, 26 Jul 2023 at 18:08, Trevor Gross <tmgross@...ch.edu> wrote:
> > >
> > [...]
> > > The guard syntax (available since 1.65) can make these kinds of match statements
> > > cleaner:
> >
> > This is unstable though.
> >
> > We try to stay away from unstable features unless we really need them,
> > which I feel is not the case here.
> >
>
> Let/else has been stable since 1.65 and is in pretty heavy use, the
> kernel is on 1.68.2 correct? Could you be thinking of let chains
> (multiple matches joined with `&&`/`||`)?

Oh, my bad. I got it mixed with "if let guard" (issue 51114).

And yeah, we're on 1.68.2, so this code can benefit from this simplification.

Thanks!

>
> >     let Some(oci_root_dir) = data.oci_root_dir else {
> >         pr_err!("missing oci_root_dir parameter!\n");
> >         return Err(ENOTSUPP);
> >     }
> > [...]