linux-kernel - Re: [PATCH v2] usb: xhci: tegra: Add shutdown callback for Tegra XUSB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f9a2e6de117df62c77eca0560785c49a8245ba8.camel@nvidia.com>
Date:   Thu, 27 Jul 2023 08:08:15 +0000
From:   Haotien Hsu <haotienh@...dia.com>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     WK Tsai <wtsai@...dia.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        Wayne Chang <waynec@...dia.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mathias.nyman@...el.com" <mathias.nyman@...el.com>,
        Jui Chang Kuo <jckuo@...dia.com>,
        Henry Lin <henryl@...dia.com>
Subject: Re: [PATCH v2] usb: xhci: tegra: Add shutdown callback for Tegra XUSB

On Tue, 2023-07-25 at 18:19 +0200, Greg Kroah-Hartman wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Tue, Jul 18, 2023 at 05:14:25PM +0800, Haotien Hsu wrote:
> > From: Henry Lin <henryl@...dia.com>
> > 
> > If memory accesses by the Tegra XUSB controller are translated
> > through
> > the SMMU (System MMU), the hardware may continue accessing memory
> > even
> > after the SMMU translations have been disabled during the shutdown
> > process and this can in turn cause unpredictable crashes.
> > Fix this by adding a shutdown implementation that ensures the
> > hardware
> > is turned off during system reboot or shutdown.
> > 
> > Signed-off-by: Henry Lin <henryl@...dia.com>
> > Signed-off-by: Haotien Hsu <haotienh@...dia.com>
> > Acked-by: Thierry Reding <treding@...dia.com>
> > 
> > ---
> > V1 -> V2: Resend for the typo in the mailing list
> > ---
> >  drivers/usb/host/xhci-tegra.c | 28 +++++++++++++++++++++-------
> >  1 file changed, 21 insertions(+), 7 deletions(-)
> 
> Does not apply against 6.5-rc4 at all :(

I rebased the patch and sent it again.
I am sorry about that.