linux-kernel - Re: [PATCH] crypto: all - alloc and init all req alloc as zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMIl1vSitJBU3UJS@gondor.apana.org.au>
Date:   Thu, 27 Jul 2023 16:07:50 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Zhang Yiqun <zhangyiqun@...tium.com.cn>
Cc:     davem@...emloft.net, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: all - alloc and init all req alloc as zero

On Thu, Jul 27, 2023 at 04:05:48PM +0800, Zhang Yiqun wrote:
> This patch is to change all req struct alloc function from kmalloc
> to kzalloc. Sometimes, it will incur some errors without initialized
> zero.
> 
> Signed-off-by: Zhang Yiqun <zhangyiqun@...tium.com.cn>
> ---
>  include/crypto/akcipher.h | 2 +-
>  include/crypto/hash.h     | 2 +-
>  include/crypto/kpp.h      | 2 +-
>  include/crypto/skcipher.h | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

Nack.  Unless you have a specific issue please don't submit vague
patches like this.  You should always state what issue led you to
make a change like this.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt