[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1eb30b9e-c43b-b81e-4d96-5d6fa4f2894a@bytedance.com>
Date: Thu, 27 Jul 2023 17:10:57 +0800
From: Qi Zheng <zhengqi.arch@...edance.com>
To: akpm@...ux-foundation.org, david@...morbit.com, tkhai@...ru,
vbabka@...e.cz, roman.gushchin@...ux.dev, djwong@...nel.org,
brauner@...nel.org, paulmck@...nel.org, tytso@....edu,
steven.price@....com, cel@...nel.org, senozhatsky@...omium.org,
yujie.liu@...el.com, gregkh@...uxfoundation.org,
muchun.song@...ux.dev
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, x86@...nel.org,
kvm@...r.kernel.org, xen-devel@...ts.xenproject.org,
linux-erofs@...ts.ozlabs.org,
linux-f2fs-devel@...ts.sourceforge.net, cluster-devel@...hat.com,
linux-nfs@...r.kernel.org, linux-mtd@...ts.infradead.org,
rcu@...r.kernel.org, netdev@...r.kernel.org,
dri-devel@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org,
dm-devel@...hat.com, linux-raid@...r.kernel.org,
linux-bcache@...r.kernel.org,
virtualization@...ts.linux-foundation.org,
linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org,
linux-xfs@...r.kernel.org, linux-btrfs@...r.kernel.org,
Muchun Song <songmuchun@...edance.com>
Subject: Re: [PATCH v3 22/49] sunrpc: dynamically allocate the sunrpc_cred
shrinker
On 2023/7/27 16:04, Qi Zheng wrote:
> Use new APIs to dynamically allocate the sunrpc_cred shrinker.
>
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>
> Reviewed-by: Muchun Song <songmuchun@...edance.com>
> ---
> net/sunrpc/auth.c | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
> index 2f16f9d17966..6b898b1be6f5 100644
> --- a/net/sunrpc/auth.c
> +++ b/net/sunrpc/auth.c
> @@ -861,11 +861,7 @@ rpcauth_uptodatecred(struct rpc_task *task)
> test_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags) != 0;
> }
>
> -static struct shrinker rpc_cred_shrinker = {
> - .count_objects = rpcauth_cache_shrink_count,
> - .scan_objects = rpcauth_cache_shrink_scan,
> - .seeks = DEFAULT_SEEKS,
> -};
> +static struct shrinker *rpc_cred_shrinker;
>
> int __init rpcauth_init_module(void)
> {
> @@ -874,9 +870,16 @@ int __init rpcauth_init_module(void)
> err = rpc_init_authunix();
> if (err < 0)
> goto out1;
> - err = register_shrinker(&rpc_cred_shrinker, "sunrpc_cred");
> - if (err < 0)
> + rpc_cred_shrinker = shrinker_alloc(0, "sunrpc_cred");
> + if (!rpc_cred_shrinker)
Here should set err to -ENOMEM, will fix.
> goto out2;
> +
> + rpc_cred_shrinker->count_objects = rpcauth_cache_shrink_count;
> + rpc_cred_shrinker->scan_objects = rpcauth_cache_shrink_scan;
> + rpc_cred_shrinker->seeks = DEFAULT_SEEKS;
> +
> + shrinker_register(rpc_cred_shrinker);
> +
> return 0;
> out2:
> rpc_destroy_authunix();
> @@ -887,5 +890,5 @@ int __init rpcauth_init_module(void)
> void rpcauth_remove_module(void)
> {
> rpc_destroy_authunix();
> - unregister_shrinker(&rpc_cred_shrinker);
> + shrinker_free(rpc_cred_shrinker);
> }
Powered by blists - more mailing lists