[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230727092631.GB8175@google.com>
Date: Thu, 27 Jul 2023 10:26:31 +0100
From: Lee Jones <lee@...nel.org>
To: Hans de Goede <hdegoede@...hat.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Henning Schild <henning.schild@...mens.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>,
linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
platform-driver-x86@...r.kernel.org,
linux-watchdog@...r.kernel.org, Pavel Machek <pavel@....cz>,
Mark Gross <markgross@...nel.org>,
Tobias Schaffner <tobias.schaffner@...mens.com>
Subject: Re: [PATCH v2 0/3] platform/x86: move simatic drivers into subdir
On Tue, 25 Jul 2023, Hans de Goede wrote:
> Hi,
>
> On 7/19/23 18:06, Andy Shevchenko wrote:
> > On Wed, Jul 19, 2023 at 05:35:15PM +0200, Henning Schild wrote:
> >> change since v1:
> >> - switch LED/wdt Kconfig to "default y"
> >> - remove guard which could hide whole siemens submenu, and default m
> >>
> >> This series does two things. It builds up a Kconfig inheritance chain
> >> for all platform device drivers, namely Watchdog and LED. And then it
> >> puts all Siemens Simatic IPC drivers in the platform/x86/ directory in
> >> a subdirectory called "siemens".
> >>
> >> That is so that users have to flip less config switches, and to ease
> >> maintenance.
> >
> > All three good enough, although I prefer the ordering that 'tristate'
> > followed by 'default' without interleaved 'depends on'. I leave it
> > to Hans. Other that that,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
> Thank you.
>
> Lee, Guenter do you want me to take the entire series on top of:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=platform-drivers-x86-simatic-ipc (aka ib-pdx86-simatic-v6.6)
>
> And send an updated pull-req ?
Please apply - no PR required for me.
> Or shall I take just 3/3 and will you take the Kconfig
> changes from 1/3 resp 2/3 directly ?
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists