[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230727095350.GF25174@pendragon.ideasonboard.com>
Date: Thu, 27 Jul 2023 12:53:50 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Ruan Jinjie <ruanjinjie@...wei.com>
Cc: mirela.rabulea@....com, linux-imx@....com, mchehab@...nel.org,
shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
festevam@...il.com, linux-arm-kernel@...ts.infradead.org,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] media: nxp: Remove redundant dev_err()
Hi Ruan,
Thank you for the patch.
On Thu, Jul 27, 2023 at 10:21:54AM +0000, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> ---
> drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 1 -
> drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> index 9512c0a61966..b7a720198ce5 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> @@ -2742,7 +2742,6 @@ static int mxc_jpeg_probe(struct platform_device *pdev)
> dev_info(&pdev->dev, "choose slot %d\n", jpeg->slot_data.slot);
> dec_irq = platform_get_irq(pdev, 0);
> if (dec_irq < 0) {
> - dev_err(&pdev->dev, "Failed to get irq %d\n", dec_irq);
> ret = dec_irq;
> goto err_irq;
> }
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
> index c4454aa1cb34..65d20e9bae69 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c
> @@ -791,7 +791,6 @@ int mxc_isi_pipe_init(struct mxc_isi_dev *isi, unsigned int id)
>
> irq = platform_get_irq(to_platform_device(isi->dev), id);
> if (irq < 0) {
> - dev_err(pipe->isi->dev, "Failed to get IRQ (%d)\n", irq);
> ret = irq;
> goto error;
> }
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists