linux-kernel - Re: [PATCH] gpio: msc313: remove unnecessary call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZMJCT0jtCzUuSnQP@smile.fi.intel.com>
Date:   Thu, 27 Jul 2023 13:09:19 +0300
From:   Andy Shevchenko <andy@...nel.org>
To:     Romain Perier <romain.perier@...il.com>
Cc:     Andrei Coardos <aboutphysycs@...il.com>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, brgl@...ev.pl,
        linus.walleij@...aro.org, daniel@...ngy.jp,
        Alexandru Ardelean <alex@...uggie.ro>
Subject: Re: [PATCH] gpio: msc313: remove unnecessary call to
 platform_set_drvdata()

On Thu, Jul 27, 2023 at 09:00:36AM +0200, Romain Perier wrote:

First of all, please do not top-post!

> The private data is "struct msc313_gpio *gpio". This private data is
> "binded" to the gpio_chip via devm_gpiochip_add_data, right ?

No.

> Then it is retrieved via gpiochip_get_data(chip), right ?

No.

The driver data is used in PM callbacks. See below.

> Le mar. 25 juil. 2023 à 15:22, Andy Shevchenko <andy@...nel.org> a écrit :
> >
> > On Fri, Jul 21, 2023 at 07:14:31PM +0300, Andy Shevchenko wrote:
> > > On Fri, Jul 21, 2023 at 04:11:57PM +0300, Andrei Coardos wrote:
> > > > This function call was found to be unnecessary as there is no equivalent
> > > > platform_get_drvdata() call to access the private data of the driver.
> >
> > Not true.

^^^^

> > > > Also, the private data is defined in this driver, so there is no risk of
> > > > it being accessed outside of this driver file.
> > >
> > > Reviewed-by: Andy Shevchenko <andy@...nel.org>
> >
> > I have to withdraw this, the patch is wrong.
> > NAK.
> >
> > Sorry for the confusion (I have looked for the wrong pattern).

-- 
With Best Regards,
Andy Shevchenko