linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: adc: mcp3911: add support for the whole MCP39xx family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <064951c6-2ddb-1488-1d4a-694e927e3215@linaro.org>
Date:   Thu, 27 Jul 2023 12:20:40 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Marcus Folkesson <marcus.folkesson@...il.com>,
        Kent Gustavsson <kent@...oris.se>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: mcp3911: add support for the
 whole MCP39xx family

On 27/07/2023 12:18, Krzysztof Kozlowski wrote:
> On 27/07/2023 12:13, Marcus Folkesson wrote:
>> Microchip does have many similar chips, add those to the compatible
>> string as the driver support is extended.
>>
>> The new supported chips are:
>>   - microchip,mcp3910
>>   - microchip,mcp3912
>>   - microchip,mcp3913
>>   - microchip,mcp3914
>>   - microchip,mcp3918
>>   - microchip,mcp3919
>>
>> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
>> ---
>>  .../devicetree/bindings/iio/adc/microchip,mcp3911.yaml      | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
>> index f7b3fde4115a..06951ec5f5da 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
>> @@ -18,7 +18,13 @@ description: |
>>  properties:
>>    compatible:
>>      enum:
>> +      - microchip,mcp3910
>>        - microchip,mcp3911
>> +      - microchip,mcp3912
>> +      - microchip,mcp3913
>> +      - microchip,mcp3914
>> +      - microchip,mcp3918
>> +      - microchip,mcp3919
> 
> Your driver suggests that they are all compatible, so maybe just use one
> as fallback?

Oh, wait, you did put match data, just not in OF, but SPI. It's fine then:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof