linux-kernel - Re: Add fchmodat2() - or add a more general syscall?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jul 2023 12:27:42 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     David Howells <dhowells@...hat.com>,
        Alexey Gladkov <legion@...nel.org>,
        James.Bottomley@...senpartnership.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, axboe@...nel.dk,
        benh@...nel.crashing.org, borntraeger@...ibm.com, bp@...en8.de,
        catalin.marinas@....com, christian@...uner.io, dalias@...c.org,
        davem@...emloft.net, deepa.kernel@...il.com, deller@....de,
        fenghua.yu@...el.com, fweimer@...hat.com, geert@...ux-m68k.org,
        glebfm@...linux.org, gor@...ux.ibm.com, hare@...e.com,
        hpa@...or.com, ink@...assic.park.msu.ru, jhogan@...nel.org,
        kim.phillips@....com, ldv@...linux.org,
        linux-alpha@...r.kernel.org, linux-arch@...r.kernel.org,
        linux-ia64@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
        linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
        linux@...linux.org.uk, linuxppc-dev@...ts.ozlabs.org,
        luto@...nel.org, mattst88@...il.com, mingo@...hat.com,
        monstr@...str.eu, mpe@...erman.id.au, namhyung@...nel.org,
        paulus@...ba.org, peterz@...radead.org, ralf@...ux-mips.org,
        sparclinux@...r.kernel.org, stefan@...er.ch, tglx@...utronix.de,
        tony.luck@...el.com, tycho@...ho.ws, will@...nel.org,
        x86@...nel.org, ysato@...rs.sourceforge.jp,
        LKML <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>, linux-api@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, viro@...iv.linux.org.uk
Subject: Re: Add fchmodat2() - or add a more general syscall?

On Wed, Jul 26, 2023 at 08:57:10PM -0700, Eric Biggers wrote:
> On Tue, Jul 25, 2023 at 04:58:34PM +0100, David Howells wrote:
> > Rather than adding a fchmodat2() syscall, should we add a "set_file_attrs()"
> > syscall that takes a mask and allows you to set a bunch of stuff all in one
> > go?  Basically, an interface to notify_change() in the kernel that would allow
> > several stats to be set atomically.  This might be of particular interest to
> > network filesystems.
> > 
> > David
> > 
> 
> fchmodat2() is a simple addition that fits well with the existing syscalls.
> It fixes an oversight in fchmodat().
> 
> IMO we should just add fchmodat2(), and not get sidetracked by trying to add
> some super-generalized syscall instead.  That can always be done later.

Agreed.