[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <BN6PR03MB33959C45BA5DBCA708AB926D9B01A@BN6PR03MB3395.namprd03.prod.outlook.com>
Date: Thu, 27 Jul 2023 11:05:46 +0000
From: "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
"jic23@...nel.org" <jic23@...nel.org>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] dt-bindings:iio:frequency:admv1013: add vcc regs
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Thursday, July 27, 2023 1:38 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@...log.com>; jic23@...nel.org;
> robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> conor+dt@...nel.org; linux-iio@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings:iio:frequency:admv1013: add vcc regs
>
> [External]
>
> On 27/07/2023 12:23, Antoniu Miclaus wrote:
> > Add bindings for the VCC regulators of the ADMV1013 microware
> > upconverter.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
>
> Subject: missing spaces between prefix parts.
I missed this comment in v2. I will add a v3 fixing the commit subject.
>
> > ---
> > .../bindings/iio/frequency/adi,admv1013.yaml | 50
> +++++++++++++++++++
> > 1 file changed, 50 insertions(+)
> >
> > diff --git
> a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> > index fc813bcb6532..6660299ac1ad 100644
> > ---
> a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> > +++
> b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> > @@ -39,6 +39,46 @@ properties:
> > description:
> > Analog voltage regulator.
> >
> > + vcc-drv-supply:
> > + description:
> > + RF Driver voltage regulator.
> > +
> > + vcc2-drv-supply:
> > + description:
> > + RF predriver voltage regulator.
> > +
> > + vcc-vva-supply:
> > + description:
> > + VVA Control Circuit voltage regulator.
> > +
> > + vcc-amp1-supply:
> > + description:
> > + RF Amplifier 1 voltage regulator.
> > +
> > + vcc-amp2-supply:
> > + description:
> > + RF Amplifier 2 voltage regulator.
> > +
> > + vcc-env-supply:
> > + description:
> > + Envelope Detector voltage regulator.
> > +
> > + vcc-bg-supply:
> > + description:
> > + Mixer Chip Band Gap Circuit voltage regulator.
> > +
> > + vcc-bg2-supply:
> > + description:
> > + VGA Chip Band Gap Circuit voltage regulator.
> > +
> > + vcc-mixer-supply:
> > + description:
> > + Mixer voltage regulator.
> > +
> > + vcc-quad-supply:
> > + description:
> > + Quadruppler voltage regulator.
> > +
>
> You made them required in the driver, so they should be required here as
> well. They should be required anyway, because AFAIU they have to be
> provided.
>
> OTOH, this will break the ABI, so your driver might need to take them as
> optional.
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists