linux-kernel - Re: [PATCH v1 2/2] clk: rockchip: rk3588: Adjust the GATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57ed9bd0-dc90-69ef-31fb-4eb5d821190d@kernel.org>
Date:   Thu, 27 Jul 2023 13:21:17 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Elaine Zhang <zhangqing@...k-chips.com>, mturquette@...libre.com,
        sboyd@...nel.org, kever.yang@...k-chips.com, heiko@...ech.de
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        huangtao@...k-chips.com
Subject: Re: [PATCH v1 2/2] clk: rockchip: rk3588: Adjust the GATE_LINK
 parameter

On 27/07/2023 12:11, Elaine Zhang wrote:
> Using Id instead of name, if use name needs to use __clk_lookup().
> But __clk_lookup() is not exported and is not friendly for GKI.
> 
> Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>
> ---

>  static void __init rk3588_clk_init(struct device_node *np)
> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> index b5616bca7b44..864a321ab362 100644
> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> @@ -733,8 +733,9 @@
>  #define ACLK_AV1_PRE			718
>  #define PCLK_AV1_PRE			719
>  #define HCLK_SDIO_PRE			720
> +#define PCLK_VO1GRF			721

Bindings are separate patches.

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof