linux-kernel - Re: [PATCH v4 00/10] Introduce SMT level and add PowerPC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2023 14:23:55 +0000
From:   "Zhang, Rui" <rui.zhang@...el.com>
To:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "ldufour@...ux.ibm.com" <ldufour@...ux.ibm.com>
CC:     "npiggin@...il.com" <npiggin@...il.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "christophe.leroy@...roup.eu" <christophe.leroy@...roup.eu>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 00/10] Introduce SMT level and add PowerPC support

Hi, Thomas,

On Fri, 2023-07-28 at 09:40 +0200, Thomas Gleixner wrote:
> Rui!
> 
> On Sun, Jul 09 2023 at 15:25, Rui Zhang wrote:
> > I ran into a boot hang regression with latest upstream code, and it
> > took me a while to bisect the offending commit and workaround it.
> 
> Where is the bug report and the analysis? And what's the workaround?

As it is an iwlwifi regression, I didn't paste the link here.

The regression was reported at
https://lore.kernel.org/all/b533071f38804247f06da9e52a04f15cce7a3836.camel@intel.com/

And it was fixed later by below commit in 6.5-rc2.

thanks,
rui

commit 12a89f0177092dbc2a1cb1d05a9790adbcea2309
Author:     Johannes Berg <johannes.berg@...el.com>
AuthorDate: Mon Jul 10 16:50:39 2023 +0200
Commit:     Jakub Kicinski <kuba@...nel.org>
CommitDate: Tue Jul 11 20:26:06 2023 -0700

    wifi: iwlwifi: remove 'use_tfh' config to fix crash
    
    This is equivalent to 'gen2', and it was always confusing to have
    two identical config entries. The split config patch actually had
    been originally developed after removing 'use_tfh" and didn't add
    the use_tfh in the new configs as they'd later been copied to the
    new files. Thus the easiest way to fix the init crash here now is
    to just remove use_tfh (which is erroneously unset in most of the
    configs now) and use 'gen2' in the code instead.
    
    There's possibly still an unwind error in iwl_txq_gen2_init() as
    it crashes if TXQ 0 fails to initialize, but we can deal with it
    later since the original failure is due to the use_tfh confusion.
    
    Tested-by: Xi Ruoyao <xry111@...111.site>
    Reported-and-tested-by: Niklāvs Koļesņikovs
<pinkflames.linux@...il.com>
    Reported-and-tested-by: Jeff Chua <jeff.chua.linux@...il.com>
    Reported-and-tested-by: Zhang Rui <rui.zhang@...el.com>
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=217622
    Link:
https://lore.kernel.org/all/9274d9bd3d080a457649ff5addcc1726f08ef5b2.camel@xry111.site/
    Link:
https://lore.kernel.org/all/CAAJw_Zug6VCS5ZqTWaFSr9sd85k%3DtyPm9DEE%2BmV%3DAKoECZM%2BsQ@mail.gmail.com/
    Fixes: 19898ce9cf8a ("wifi: iwlwifi: split 22000.c into multiple
files")
    Signed-off-by: Johannes Berg <johannes.berg@...el.com>
    Link:
https://lore.kernel.org/r/20230710145038.84186-2-johannes@sipsolutions.net
    Signed-off-by: Jakub Kicinski <kuba@...nel.org>

> 
> Thanks,
> 
>         tglx