linux-kernel - Re: [PATCH v3 0/5] drm/amdgpu: Add new reset option and rework coredump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24fc3974-a303-e792-b6d5-5ca634c2bc4b@igalia.com>
Date:   Fri, 28 Jul 2023 11:45:42 -0300
From:   André Almeida <andrealmeid@...lia.com>
To:     christian.koenig@....com
Cc:     kernel-dev@...lia.com, alexander.deucher@....com,
        amd-gfx@...ts.freedesktop.org, pierre-eric.pelloux-prayer@....com,
        'Marek Olšák' <maraeo@...il.com>,
        linux-kernel@...r.kernel.org,
        Samuel Pitoiset <samuel.pitoiset@...il.com>,
        Bas Nieuwenhuizen <bas@...nieuwenhuizen.nl>,
        Timur Kristóf <timur.kristof@...il.com>,
        michel.daenzer@...lbox.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v3 0/5] drm/amdgpu: Add new reset option and rework
 coredump

Hi Christian, gently ping here

Em 14/07/2023 13:11, André Almeida escreveu:
> Hi,
> 
> The goal of this patchset is to improve debugging device resets on amdgpu.
> 
> The first patch creates a new module parameter to disable soft recoveries,
> ensuring every recovery go through the full device reset, making easier to
> generate resets from userspace tools like [0] and [1]. This is important to
> validate how the stack behaves on resets, from end-to-end.
> 
> The last patches are a rework to alloc devcoredump dynamically and to move it to
> a better source file.
> 
> I have dropped the patches that add more information to devcoredump for now,
> until I figure out a better way to do so, like storing the IB address in the
> fence.
> 
> Thanks,
> 	André
> 
> [0] https://gitlab.freedesktop.org/andrealmeid/gpu-timeout
> [1] https://github.com/andrealmeid/vulkan-triangle-v1
> 
> Changelog:
> 
> v2: https://lore.kernel.org/dri-devel/20230713213242.680944-1-andrealmeid@igalia.com/
> - Drop the IB and ring patch
> - Drop patch that limited information from kernel threads
> - Add patch to move coredump to amdgpu_reset
> 
> v1: https://lore.kernel.org/dri-devel/20230711213501.526237-1-andrealmeid@igalia.com/
>   - Drop "Mark contexts guilty for causing soft recoveries" patch
>   - Use GFP_NOWAIT for devcoredump allocation
> 
> André Almeida (5):
>    drm/amdgpu: Create a module param to disable soft recovery
>    drm/amdgpu: Allocate coredump memory in a nonblocking way
>    drm/amdgpu: Rework coredump to use memory dynamically
>    drm/amdgpu: Move coredump code to amdgpu_reset file
>    drm/amdgpu: Create version number for coredumps
> 
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h        |  6 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 67 +-----------------
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c    |  9 +++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c  | 79 ++++++++++++++++++++++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h  | 14 ++++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c   |  6 +-
>   6 files changed, 111 insertions(+), 70 deletions(-)
>