[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <16326cd3-376b-4d08-409e-e64f43f848af@bytedance.com>
Date: Fri, 28 Jul 2023 11:01:23 +0800
From: Chuyi Zhou <zhouchuyi@...edance.com>
To: Quentin Monnet <quentin@...valent.com>, hannes@...xchg.org,
mhocko@...nel.org, roman.gushchin@...ux.dev, ast@...nel.org,
daniel@...earbox.net, andrii@...nel.org
Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
wuyun.abel@...edance.com, robin.lu@...edance.com
Subject: Re: [RFC PATCH 3/5] libbpf, bpftool: Support BPF_PROG_TYPE_OOM_POLICY
Hi,
在 2023/7/27 20:26, Quentin Monnet 写道:
> 2023-07-27 15:36 UTC+0800 ~ Chuyi Zhou <zhouchuyi@...edance.com>
>> Support BPF_PROG_TYPE_OOM_POLICY program in libbpf and bpftool, so that
>> we can identify and use BPF_PROG_TYPE_OOM_POLICY in our application.
>>
>> Signed-off-by: Chuyi Zhou <zhouchuyi@...edance.com>
>> ---
>> tools/bpf/bpftool/common.c | 1 +
>> tools/include/uapi/linux/bpf.h | 14 ++++++++++++++
>> tools/lib/bpf/libbpf.c | 3 +++
>> tools/lib/bpf/libbpf_probes.c | 2 ++
>> 4 files changed, 20 insertions(+)
>>
>> diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c
>> index cc6e6aae2447..c5c311299c4a 100644
>> --- a/tools/bpf/bpftool/common.c
>> +++ b/tools/bpf/bpftool/common.c
>> @@ -1089,6 +1089,7 @@ const char *bpf_attach_type_input_str(enum bpf_attach_type t)
>> case BPF_TRACE_FENTRY: return "fentry";
>> case BPF_TRACE_FEXIT: return "fexit";
>> case BPF_MODIFY_RETURN: return "mod_ret";
>> + case BPF_OOM_POLICY: return "oom_policy";
>
> This case is not necessary. This block is here to keep legacy attach
> type strings supported by bpftool. In your case, the name is the same as
> the one provided by libbpf, so...
>
>> case BPF_SK_REUSEPORT_SELECT: return "sk_skb_reuseport_select";
>> case BPF_SK_REUSEPORT_SELECT_OR_MIGRATE: return "sk_skb_reuseport_select_or_migrate";
>> default: return libbpf_bpf_attach_type_str(t);
>
> ... we just want to pick it up from libbpf directly, here.
>
I see..
Thanks.
--
Chuyi Zhou
> [...]
>
>> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
>> index 214f828ece6b..10496bb9b3bc 100644
>> --- a/tools/lib/bpf/libbpf.c
>> +++ b/tools/lib/bpf/libbpf.c
>> @@ -118,6 +118,7 @@ static const char * const attach_type_name[] = {
>> [BPF_TRACE_KPROBE_MULTI] = "trace_kprobe_multi",
>> [BPF_STRUCT_OPS] = "struct_ops",
>> [BPF_NETFILTER] = "netfilter",
>> + [BPF_OOM_POLICY] = "oom_policy",
>> };
>
Powered by blists - more mailing lists