linux-kernel - [PATCH V2] cpu/SMT: Fix cpu_smt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230728155313.44170-1-rui.zhang@intel.com>
Date:   Fri, 28 Jul 2023 23:53:13 +0800
From:   Zhang Rui <rui.zhang@...el.com>
To:     tglx@...utronix.de, peterz@...radead.org
Cc:     linux-kernel@...r.kernel.org, vkuznets@...hat.com
Subject: [PATCH V2] cpu/SMT: Fix cpu_smt_possible() comment

Commit e1572f1d08be ("cpu/SMT: create and export cpu_smt_possible()")
introduces cpu_smt_possible() to represent if SMT is theoretically
possible. It returns true when SMT is supported and not forcefully
disabled ('nosmt=force'). But the comment of it says "Returns true if
SMT is not supported of forcefully (irreversibly) disabled", which is
wrong. Fix that comment accordingly.

Signed-off-by: Zhang Rui <rui.zhang@...el.com>
Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>
---
Changes since V1
 - rephrase the changelog
---
 kernel/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index 88a7ede322bd..050dda751fc3 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -642,7 +642,7 @@ static inline bool cpu_smt_allowed(unsigned int cpu)
 	return !cpumask_test_cpu(cpu, &cpus_booted_once_mask);
 }
 
-/* Returns true if SMT is not supported of forcefully (irreversibly) disabled */
+/* Returns true if SMT is supported and not forcefully (irreversibly) disabled */
 bool cpu_smt_possible(void)
 {
 	return cpu_smt_control != CPU_SMT_FORCE_DISABLED &&
-- 
2.34.1