linux-kernel - Re: [PATCH 11/33] iris: vidc: add helpers for memory management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230728162817.GE1428172@hu-bjorande-lv.qualcomm.com>
Date:   Fri, 28 Jul 2023 09:28:17 -0700
From:   Bjorn Andersson <quic_bjorande@...cinc.com>
To:     Vikash Garodia <quic_vgarodia@...cinc.com>
CC:     <stanimir.k.varbanov@...il.com>, <agross@...nel.org>,
        <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <mchehab@...nel.org>, <hans.verkuil@...co.com>,
        <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <quic_dikshita@...cinc.com>
Subject: Re: [PATCH 11/33] iris: vidc: add helpers for memory management

On Fri, Jul 28, 2023 at 06:53:22PM +0530, Vikash Garodia wrote:
> diff --git a/drivers/media/platform/qcom/iris/vidc/src/msm_vidc_memory.c b/drivers/media/platform/qcom/iris/vidc/src/msm_vidc_memory.c
[..]
> +static const struct msm_vidc_memory_ops msm_mem_ops = {
> +	.dma_buf_get                    = msm_vidc_dma_buf_get,
> +	.dma_buf_put                    = msm_vidc_dma_buf_put,
> +	.dma_buf_put_completely         = msm_vidc_dma_buf_put_completely,
> +	.dma_buf_attach                 = msm_vidc_dma_buf_attach,
> +	.dma_buf_detach                 = msm_vidc_dma_buf_detach,
> +	.dma_buf_map_attachment         = msm_vidc_dma_buf_map_attachment,
> +	.dma_buf_unmap_attachment       = msm_vidc_dma_buf_unmap_attachment,
> +	.memory_alloc_map               = msm_vidc_memory_alloc_map,
> +	.memory_unmap_free              = msm_vidc_memory_unmap_free,
> +	.buffer_region                  = msm_vidc_buffer_region,

Will there ever be more than one implementation of the
msm_vidc_memory_ops?

Unless there's a really strong reason, just call the functions directly
without the function pointers and call_mem_op(), this will be slightly
faster, but more importantly it allows for much faster navigation of the
code base.

Regards,
Bjorn