linux-kernel - Re: [PATCH V1 1/2] regulator: aw37503: add regulator driver for AWINIC AW37503

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230728032004.1479251-1-like@awinic.com>
Date:   Fri, 28 Jul 2023 03:20:04 +0000
From:   like@...nic.com
To:     broonie@...nel.org
Cc:     conor+dt@...nel.org, devicetree@...r.kernel.org,
        krzysztof.kozlowski+dt@...aro.org, lgirdwood@...il.com,
        liangdong@...nic.com, like@...nic.com,
        linux-kernel@...r.kernel.org, liweilei@...nic.com,
        robh+dt@...nel.org, wangweidong.a@...nic.com
Subject: Re: [PATCH V1 1/2] regulator: aw37503: add regulator driver for AWINIC AW37503

Hello Mark Brown,
Thank you very much for your advice.

> On Wed, Jul 26, 2023 at 08:16:11AM +0000, like@...nic.com wrote:
> 
> > @@ -191,5 +191,6 @@ obj-$(CONFIG_REGULATOR_WM831X) += wm831x-ldo.o
> >  obj-$(CONFIG_REGULATOR_WM8350) += wm8350-regulator.o
> >  obj-$(CONFIG_REGULATOR_WM8400) += wm8400-regulator.o
> >  obj-$(CONFIG_REGULATOR_WM8994) += wm8994-regulator.o
> > +obj-$(CONFIG_REGULATOR_AW37503) += aw37503-regulator.o
> >  
> 
> Please keep the Kconfig and Makefile sorted.

I will modify the sorting of AW37503 as suggested.

> > +static const struct regmap_config aw37503_regmap_config = {
> > +	.reg_bits	= 8,
> > +	.val_bits	= 8,
> > +	.max_register	= AW37503_REG_WPRTEN,
> > +	.cache_type	= REGCACHE_NONE,
> 
> No need to specify no cache, it's the default.

I will modify it as suggested.


Best regards,
Alec Li