linux-kernel - Re: [PATCH v2] x86/APM: drop the duplicate APM_MINOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81d25f6b-5498-0996-650e-810f202a9d73@intel.com>
Date:   Fri, 28 Jul 2023 09:51:11 -0700
From:   Sohil Mehta <sohil.mehta@...el.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        <linux-kernel@...r.kernel.org>
CC:     Jiri Kosina <jikos@...nel.org>, <x86@...nel.org>,
        Corentin Labbe <clabbe.montjoie@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2] x86/APM: drop the duplicate APM_MINOR_DEV macro

Just a nit, the tip tree handbook says:

> "The condensed patch description in the subject line should start with
> a uppercase letter and ..."

https://docs.kernel.org/process/maintainer-tip.html?highlight=tip+maintainer#patch-subject

On 7/27/2023 6:11 PM, Randy Dunlap wrote:
> This source file already includes <linux/miscdevice.h>, which contains
> the same macro. It doesn't need to be defined here again.
> 
> Fixes: 874bcd00f520 ("apm-emulation: move APM_MINOR_DEV to include/linux/miscdevice.h")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Reviewed-by: Sohil Mehta <sohil.mehta@...el.com>