[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230728171211.3016019-1-hugo@hugovil.com>
Date: Fri, 28 Jul 2023 13:12:12 -0400
From: Hugo Villeneuve <hugo@...ovil.com>
To: Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: hugo@...ovil.com, Hugo Villeneuve <hvilleneuve@...onoff.com>,
linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [RESEND PATCH v2] rtc: pcf2127: add error checking when disabling POR0
From: Hugo Villeneuve <hvilleneuve@...onoff.com>
If PCF2127 device is absent from the I2C bus, or if there is a
communication problem, disabling POR0 may fail silently and we
still continue with probing the device. In that case, abort probe
operation.
Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
---
V1 -> V2: Removed error message
---
drivers/rtc/rtc-pcf2127.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c
index 78141bb06ab0..3387afe93417 100644
--- a/drivers/rtc/rtc-pcf2127.c
+++ b/drivers/rtc/rtc-pcf2127.c
@@ -1192,8 +1192,10 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap,
* The "Power-On Reset Override" facility prevents the RTC to do a reset
* after power on. For normal operation the PORO must be disabled.
*/
- regmap_clear_bits(pcf2127->regmap, PCF2127_REG_CTRL1,
+ ret = regmap_clear_bits(pcf2127->regmap, PCF2127_REG_CTRL1,
PCF2127_BIT_CTRL1_POR_OVRD);
+ if (ret < 0)
+ return ret;
ret = regmap_read(pcf2127->regmap, pcf2127->cfg->reg_clkout, &val);
if (ret < 0)
base-commit: 3c87b351809f220294aec3c0df7b078ff5c5b15b
--
2.30.2
Powered by blists - more mailing lists