[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <2c0ac97f9c8e6bd46b60854c136099c0dd4a09f6.1690564372.git.skhan@linuxfoundation.org>
Date: Fri, 28 Jul 2023 11:29:28 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: shuah@...nel.org, Liam.Howlett@...cle.com,
anjali.k.kulkarni@...cle.com, kuba@...nel.org
Cc: Shuah Khan <skhan@...uxfoundation.org>, davem@...emloft.net,
linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH next 3/3] selftests:connector: Add root check and fix arg error paths to skip
proc_filter test requires root privileges. Add root privilege check
and skip the test. Also fix argument parsing paths to skip in their
error legs.
Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>
---
tools/testing/selftests/connector/proc_filter.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c
index 4fe8c6763fd8..7b2081b98e5c 100644
--- a/tools/testing/selftests/connector/proc_filter.c
+++ b/tools/testing/selftests/connector/proc_filter.c
@@ -248,7 +248,7 @@ int main(int argc, char *argv[])
if (argc > 2) {
printf("Expected 0(assume no-filter) or 1 argument(-f)\n");
- exit(1);
+ exit(KSFT_SKIP);
}
if (argc == 2) {
@@ -256,10 +256,15 @@ int main(int argc, char *argv[])
filter = 1;
} else {
printf("Valid option : -f (for filter feature)\n");
- exit(1);
+ exit(KSFT_SKIP);
}
}
+ if (geteuid()) {
+ printf("Connector test requires root privileges.\n");
+ exit(KSFT_SKIP);
+ }
+
if (filter) {
input.event_type = PROC_EVENT_NONZERO_EXIT;
input.mcast_op = PROC_CN_MCAST_LISTEN;
--
2.39.2
Powered by blists - more mailing lists