[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5065221.NG923GbCHz@phil>
Date: Fri, 28 Jul 2023 20:24:42 +0200
From: Heiko Stuebner <heiko@...ech.de>
To: Jaehoon Chung <jh80.chung@...sung.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
Yangtao Li <frank.li@...o.com>
Cc: Yangtao Li <frank.li@...o.com>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, linux-mmc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 41/62] mmc: dw_mmc: rockchip: Convert to platform remove
callback returning void
Am Donnerstag, 27. Juli 2023, 09:00:30 CEST schrieb Yangtao Li:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Signed-off-by: Yangtao Li <frank.li@...o.com>
Acked-by: Heiko Stuebner <heiko@...ech.de>
Powered by blists - more mailing lists