linux-kernel - Re: [PATCH 3/3] arm64: dts: Replace the IRQ number with the IRQID macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7hh6pnhn45.fsf@baylibre.com>
Date:   Fri, 28 Jul 2023 12:06:34 -0700
From:   Kevin Hilman <khilman@...libre.com>
To:     Huqiang Qin <huqiang.qin@...ogic.com>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        neil.armstrong@...aro.org, jbrunet@...libre.com,
        martin.blumenstingl@...glemail.com, linus.walleij@...aro.org
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: Replace the IRQ number with the IRQID
 macro definition

Huqiang Qin <huqiang.qin@...ogic.com> writes:

> Hi Kevin Hilman,
>
> On 2023/7/27 6:33, Kevin Hilman wrote:
>>> Replacing IRQ numbers with IRQID macro definitions makes node properties
>>> easier to understand and also makes GPIO interrupts easier to use.
>>>
>>> Associated platforms:
>>> - Amlogic Meson-G12A
>>> - Amlogic Meson-G12B
>>> - Amlogic Meson-SM1
>> Does this mean you tested/validated these changes on those platforms
>> also?
>
> Amlogic's G12A/G12B/SM1 have the same GPIO, and the GPIO interrupt number
> is also the same, so I only tested on the SM1 platform, and the test results
> prove that these changes are good.

OK, thank you for the explanation.

For future reference, this kind of detail is helpful to describe in the
patch or cover letter so maintainers & reviewers better understand how
the changes were tested.

Thanks,

Kevin