linux-kernel - Re: [PATCH v3 27/50] dt-bindings: usb: atmel: add sam9x7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2023 13:15:18 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Varshini Rajendran <varshini.rajendran@...rochip.com>,
        gregkh@...uxfoundation.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, claudiu.beznea@...rochip.com,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 27/50] dt-bindings: usb: atmel: add sam9x7

On Fri, Jul 28, 2023 at 06:42:53PM +0200, Krzysztof Kozlowski wrote:
> On 28/07/2023 12:27, Varshini Rajendran wrote:
> > Add sam9x7 bindings.
> > 
> > Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> > ---
> >  Documentation/devicetree/bindings/usb/atmel-usb.txt | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > index 12183ef47ee4..82bd0dbc2a48 100644
> > --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > @@ -3,8 +3,9 @@ Atmel SOC USB controllers
> >  OHCI
> >  
> >  Required properties:
> > - - compatible: Should be "atmel,at91rm9200-ohci" for USB controllers
> > -   used in host mode.
> > + - compatible: Should be "atmel,at91rm9200-ohci" or
> > +   "microchip,sam9x7-ohci", "atmel,at91rm9200-ohci"
> > +   for USB controllers used in host mode.
> >   - reg: Address and length of the register set for the device
> >   - interrupts: Should contain ohci interrupt
> >   - clocks: Should reference the peripheral, host and system clocks
> > @@ -30,8 +31,9 @@ usb0: ohci@...000 {
> >  EHCI
> >  
> >  Required properties:
> > - - compatible: Should be "atmel,at91sam9g45-ehci" for USB controllers
> > -   used in host mode.
> > + - compatible: Should be "atmel,at91sam9g45-ehci" or
> > +   "microchip,sam9x7-ehci", "atmel,at91sam9g45-ehci"
> 
> This confuses me. Isn't microchip,sam9x7-ehci already described in EHCI
> bindings?

The Atmel .dts (including the one in this series) files use usb-ohci and 
usb-ehci compatibles, but they have extra properties (and clocks are 
different IIRC). So they aren't 'generic' and should drop those 
compatibles. There's already warnings generated for this, but obviously 
no one is paying attention.

Rob