linux-kernel - Re: [PATCH next 3/3] selftests:connector: Add root check and fix arg error paths to skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16B47831-5F53-4BAF-B347-A1404D2ED264@oracle.com>
Date:   Fri, 28 Jul 2023 21:21:07 +0000
From:   Anjali Kulkarni <anjali.k.kulkarni@...cle.com>
To:     Shuah Khan <skhan@...uxfoundation.org>
CC:     Shuah Khan <shuah@...nel.org>,
        Liam Howlett <liam.howlett@...cle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH next 3/3] selftests:connector: Add root check and fix arg
 error paths to skip



> On Jul 28, 2023, at 12:44 PM, Shuah Khan <skhan@...uxfoundation.org> wrote:
> 
> On 7/28/23 13:06, Shuah Khan wrote:
>> On 7/28/23 12:10, Anjali Kulkarni wrote:
>>> 
>>> 
>>>> On Jul 28, 2023, at 10:29 AM, Shuah Khan <skhan@...uxfoundation.org> wrote:
>>>> 
>>>> proc_filter test requires root privileges. Add root privilege check
>>>> and skip the test. Also fix argument parsing paths to skip in their
>>>> error legs.
>>>> 
>>>> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>
>>>> ---
>>>> tools/testing/selftests/connector/proc_filter.c | 9 +++++++--
>>>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>>> 
>>>> diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c
>>>> index 4fe8c6763fd8..7b2081b98e5c 100644
>>>> --- a/tools/testing/selftests/connector/proc_filter.c
>>>> +++ b/tools/testing/selftests/connector/proc_filter.c
>>>> @@ -248,7 +248,7 @@ int main(int argc, char *argv[])
>>>> 
>>>> if (argc > 2) {
>>>> printf("Expected 0(assume no-filter) or 1 argument(-f)\n");
>>>> -  exit(1);
>>>> +  exit(KSFT_SKIP);
>>>> }
>>>> 
>>>> if (argc == 2) {
>>>> @@ -256,10 +256,15 @@ int main(int argc, char *argv[])
>>>> filter = 1;
>>>> } else {
>>>> printf("Valid option : -f (for filter feature)\n");
>>>> -  exit(1);
>>>> +  exit(KSFT_SKIP);
>>>> }
>>>> }
>>>> 
>>>> +  if (geteuid()) {
>>>> +  printf("Connector test requires root privileges.\n");
>>>> +  exit(KSFT_SKIP);
>>>> +  }
>>>> +
>>> 
>>> I am not sure why you have added this check? proc_filter does not need root privilege to run.
>>> 
>> It failed for me when I ran it saying it requires root privileges.
>> I had to run it as root.
> 
> The following is what I see when I run the test as non-root
> user:
> 
> bind failed: Operation not permitted
> 

Yes, that’s expected on a kernel which does not have the kernel patches submitted with this selftest installed on it. 
So this check for root needs to be removed.

Anjali

> thanks,
> -- Shuah