linux-kernel - Re: [PATCH -next] mfd: max77686: Remove unused extern declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 29 Jul 2023 06:55:21 +0900
From:   Chanwoo Choi <chanwoo@...nel.org>
To:     Yue Haibing <yuehaibing@...wei.com>, cw00.choi@...sung.com,
        krzysztof.kozlowski@...aro.org, lee@...nel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] mfd: max77686: Remove unused extern declarations

On 23. 7. 28. 22:27, Yue Haibing wrote:
> max77686_irq_init() and max77686_irq_exit() are not used since
> commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq").
> And max77686_irq_resume() never be implemented since introduced in
> commit dae8a969d512 ("mfd: Add Maxim 77686 driver").
> 
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
>  include/linux/mfd/max77686-private.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/linux/mfd/max77686-private.h b/include/linux/mfd/max77686-private.h
> index 3acceeedbaba..ea635d12a741 100644
> --- a/include/linux/mfd/max77686-private.h
> +++ b/include/linux/mfd/max77686-private.h
> @@ -441,8 +441,4 @@ enum max77686_types {
>  	TYPE_MAX77802,
>  };
>  
> -extern int max77686_irq_init(struct max77686_dev *max77686);
> -extern void max77686_irq_exit(struct max77686_dev *max77686);
> -extern int max77686_irq_resume(struct max77686_dev *max77686);
> -
>  #endif /*  __LINUX_MFD_MAX77686_PRIV_H */

Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>
-- 
Best Regards,
Samsung Electronics
Chanwoo Choi