[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1399c766-791b-486d-90d5-a00999eb15fb@kadam.mountain>
Date: Fri, 28 Jul 2023 08:51:35 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Krishna chaitanya chundru <quic_krichai@...cinc.com>
Cc: manivannan.sadhasivam@...aro.org, helgaas@...nel.org,
linux-pci@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org, quic_vbadigan@...cinc.com,
quic_nitegupt@...cinc.com, quic_skananth@...cinc.com,
quic_ramkri@...cinc.com, krzysztof.kozlowski@...aro.org,
Manivannan Sadhasivam <mani@...nel.org>,
Jeffrey Hugo <quic_jhugo@...cinc.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Dan Carpenter <error27@...il.com>,
"Rafael J. Wysocki" <rafael@...nel.org>,
"open list:MHI BUS" <mhi@...ts.linux.dev>
Subject: Re: [PATCH v4 9/9] bus: mhi: ep: wake up host if the MHI state is in
M3
On Thu, Jul 13, 2023 at 12:40:18PM +0530, Krishna chaitanya chundru wrote:
> @@ -464,6 +484,13 @@ int mhi_ep_queue_skb(struct mhi_ep_device *mhi_dev, struct sk_buff *skb)
> buf_left = skb->len;
> ring = &mhi_cntrl->mhi_chan[mhi_chan->chan].ring;
>
> + if (mhi_cntrl->mhi_state == MHI_STATE_M3) {
> + if (mhi_ep_wake_host(mhi_cntrl)) {
> + dev_err(dev, "Failed to wakeup host\n");
> + return -ENODEV;
> + }
Since you're going to be redoing this patch anyway could you please
propage the error code:
ret = mhi_ep_wake_host(mhi_cntrl);
if (ret) {
dev_err(dev, "Failed to wakeup host\n");
return ret;
}
regards,
dan carpenter
Powered by blists - more mailing lists