linux-kernel - RE: [PATCH v3 1/2] ASoC: Intel: maxim-common: get codec number from ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2023 06:10:44 +0000
From:   "Lu, Brent" <brent.lu@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "Rojewski, Cezary" <cezary.rojewski@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ajye Huang <ajye_huang@...pal.corp-partner.google.com>,
        "Zhi, Yong" <yong.zhi@...el.com>,
        Terry Cheong <htcheong@...omium.org>,
        "Bhat, Uday M" <uday.m.bhat@...el.com>,
        "Chiang, Mac" <mac.chiang@...el.com>,
        "R, Dharageswari" <dharageswari.r@...el.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        ye xingchen <ye.xingchen@....com.cn>
Subject: RE: [PATCH v3 1/2] ASoC: Intel: maxim-common: get codec number from
 ACPI


> >  static int max_98390_hw_params(struct snd_pcm_substream *substream,
> >  			       struct snd_pcm_hw_params *params)  {
> >  	struct snd_soc_pcm_runtime *rtd =
> asoc_substream_to_rtd(substream);
> >  	struct snd_soc_dai *codec_dai;
> > +	int i, ret = 0;
> 
> Redundant assignment.
> 
Will fix it in v4 patch.

> 
> Maybe (maybe, don't know subsystem preferences)
> 
> #define MAX_98390_DEV0_NAME	"i2c-" MAX_98390_ACPI_HID ":00"
> #define MAX_98390_DEV1_NAME	"i2c-" MAX_98390_ACPI_HID ":01"
> #define MAX_98390_DEV2_NAME	"i2c-" MAX_98390_ACPI_HID ":02"
> #define MAX_98390_DEV3_NAME	"i2c-" MAX_98390_ACPI_HID ":03"
> 

Will include this change in v4 patch. Thanks for reviewing.

Regards,
Brent