linux-kernel - Re: [PATCH 2/3] dt-bindings: leds: Add binding for Broadchip BCT3024 LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4c15d67-3cbd-3c02-cfa3-54d52d0b85dd@linaro.org>
Date:   Fri, 28 Jul 2023 09:31:26 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Matus Gajdos <matuszpd@...il.com>, Pavel Machek <pavel@....cz>,
        Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: leds: Add binding for Broadchip BCT3024
 LED driver

On 27/07/2023 18:05, Matus Gajdos wrote:
> The BCT3024 chip is an I2C LED driver with independent 24 output
> channels. Each channel supports 256 levels.
> 
> Signed-off-by: Matus Gajdos <matuszpd@...il.com>

Thank you for your patch. There is something to discuss/improve.

A nit, subject: drop second/last, redundant "binding for". The
"dt-bindings" prefix is already stating that these are bindings.

> ---
>  .../bindings/leds/broadchip,bct3024.yaml      | 89 +++++++++++++++++++
>  1 file changed, 89 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/broadchip,bct3024.yaml
> 
> diff --git a/Documentation/devicetree/bindings/leds/broadchip,bct3024.yaml b/Documentation/devicetree/bindings/leds/broadchip,bct3024.yaml
> new file mode 100644
> index 000000000000..0d622894e79c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/broadchip,bct3024.yaml
> @@ -0,0 +1,89 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/broadchip,bct3024.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadchip BCT3024 LED Driver
> +
> +maintainers:
> +  - Matus Gajdos <matuszpd@...il.com>
> +
> +description: |
> +  The BCT3024 is an I2C LED driver with independent 24 output channels. Each
> +  channel supports 256 levels and its output current can be scaled by a factor
> +  of 1, 1/2, 1/3 and 1/4.
> +
> +properties:
> +  compatible:
> +    const: broadchip,bct3024
> +
> +  reg:
> +    description: I2C slave address of the driver.

Drop description, it is obvious.

> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Regulator providing power to the VDD pin.
> +
> +  shutdown-gpios:

powerdown-gpios instead. See gpio-consumer-common.yaml

> +    maxItems: 1

And this won't be needed.

> +    description: GPIO attached to the SDB pin.
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +


Best regards,
Krzysztof