linux-kernel - Re: [PATCH blktests v1 04/11] nvme: Use def_subsysnqn variable instead local variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yiandzaqpwhcvxrc3xsdtdplxss4nknkiseoiwc2cgokldlyil@deykhee2rr7g>
Date:   Fri, 28 Jul 2023 08:04:41 +0000
From:   Shinichiro Kawasaki <shinichiro.kawasaki@....com>
To:     Daniel Wagner <dwagner@...e.de>
CC:     "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Max Gurtovoy <mgurtovoy@...dia.com>,
        Hannes Reinecke <hare@...e.de>,
        Sagi Grimberg <sagi@...mberg.me>,
        James Smart <jsmart2021@...il.com>
Subject: Re: [PATCH blktests v1 04/11] nvme: Use def_subsysnqn variable
 instead local variable

On Jul 26, 2023 / 14:46, Daniel Wagner wrote:
> As all tests are using the same subsystem nqn anyway, use
> the def_subsysnqn variable and drop the local subsys_name
> variable.

[...]

> diff --git a/tests/nvme/043 b/tests/nvme/043
> index 4a37f91e50c3..6392bd8b2492 100755
> --- a/tests/nvme/043
> +++ b/tests/nvme/043
> @@ -26,7 +26,6 @@ test() {
>  	_setup_nvmet
>  
>  	local port
> -	local subsys_name="blktests-subsystem-1"

The variable subsys_name is removed here, but this patch still leaves a
reference to it. This causes this test case fail. The reference is removed in
the next patch. I think the left reference should be replaced with def_subsysnqn
in this patch.