linux-kernel - Re: [PATCH blktests v1 11/11] nvme: Add explicitly host to allow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2023 08:15:45 +0000
From:   Shinichiro Kawasaki <shinichiro.kawasaki@....com>
To:     Daniel Wagner <dwagner@...e.de>
CC:     "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Max Gurtovoy <mgurtovoy@...dia.com>,
        Hannes Reinecke <hare@...e.de>,
        Sagi Grimberg <sagi@...mberg.me>,
        James Smart <jsmart2021@...il.com>
Subject: Re: [PATCH blktests v1 11/11] nvme: Add explicitly host to allow_host
 list

On Jul 26, 2023 / 14:46, Daniel Wagner wrote:
> Only allow to connect to our setup target with the correct hostnqn.
> 
> Thus we have to explicitly add the test hostnqn to the test subsysnqn
> allow_host list.

[...]

> --- a/tests/nvme/030
> +++ b/tests/nvme/030
> @@ -28,6 +28,7 @@ test() {
>  
>  	_create_nvmet_subsystem "${subsys}1" "$(losetup -f)"
>  	_add_nvmet_subsys_to_port "${port}" "${subsys}1"
> +	_create_nvmet_host "${subsys}1" "${def_hostnqn}"
>  
>  	genctr=$(_discovery_genctr)
>  
> @@ -36,13 +37,13 @@ test() {
>  
>  	genctr=$(_check_genctr "${genctr}" "adding a subsystem to a port")
>  
> -	echo 0 > "${NVMET_CFS}/subsystems/${subsys}2/attr_allow_any_host"
> +	_add_nvmet_allow_hosts "${subsys}2" "${def_hostnqn}"
>  
> -	genctr=$(_check_genctr "${genctr}" "clearing attr_allow_any_host")
> +	genctr=$(_check_genctr "${genctr}" "adding host to allow_hosts")
>  
> -	echo 1 > "${NVMET_CFS}/subsystems/${subsys}2/attr_allow_any_host"
> +	_remove_nvmet_allow_hosts "${subsys}2" "${def_hostnqn}"
>  
> -	genctr=$(_check_genctr "${genctr}" "setting attr_allow_any_host")
> +	genctr=$(_check_genctr "${genctr}" "removing host from allow_hosts")
>  
>  	_remove_nvmet_subsystem_from_port "${port}" "${subsys}2"
>  	_remove_nvmet_subsystem "${subsys}2"

The hunk above looks different from other changes. Is it changing test
content slightly to meet request by Max? If so, it would be good to note
in the commit message.