| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <c134dae7-38ba-baca-38ba-e06bbc6a491b@kernel.org>
Date: Fri, 28 Jul 2023 10:21:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Umang Jain <umang.jain@...asonboard.com>,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: Lee Jackson <lee.jackson@...ucam.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Hans Verkuil <hverkuil-cisco@...all.nl>,
Shawn Tu <shawnx.tu@...el.com>,
Nicholas Roth <nicholas@...hemail.net>,
Mikhail Rudenko <mike.rudenko@...il.com>,
kieran.bingham@...asonboard.com,
Marco Felsch <m.felsch@...gutronix.de>,
jacopo.mondi@...asonboard.com
Subject: Re: [PATCH 2/2] media: i2c: imx519: Support for the Sony IMX519
sensor
On 27/07/2023 17:41, Umang Jain wrote:
> From: Lee Jackson <lee.jackson@...ucam.com>
>
> Adds a driver for the 16MPix IMX519 CSI2 sensor.
> Whilst the sensor supports 2 or 4 CSI2 data lanes, this driver
> currently only supports 2 lanes. The driver also supports
> Phase Detection Auto Focus (PDAF).
Thank you for your patch. There is something to discuss/improve.
> +
> +error_out:
> + v4l2_fwnode_endpoint_free(&ep_cfg);
> + fwnode_handle_put(endpoint);
> +
> + return ret;
> +}
> +
> +static const struct of_device_id imx519_dt_ids[] = {
> + { .compatible = "sony,imx519"},
> + { /* sentinel */ }
> +};
> +
> +static int imx519_probe(struct i2c_client *client)
> +{
> + struct device *dev = &client->dev;
> + struct imx519 *imx519;
> + const struct of_device_id *match;
> + u32 xclk_freq;
> + int ret;
> +
> + imx519 = devm_kzalloc(&client->dev, sizeof(*imx519), GFP_KERNEL);
> + if (!imx519)
> + return -ENOMEM;
> +
> + v4l2_i2c_subdev_init(&imx519->sd, client, &imx519_subdev_ops);
> +
> + match = of_match_device(imx519_dt_ids, dev);
> + if (!match)
> + return -ENODEV;
> +
> + /* Check the hardware configuration in device tree */
> + if (imx519_check_hwcfg(dev))
> + return -EINVAL;
> +
> + /* Get system clock (xclk) */
> + imx519->xclk = devm_clk_get(dev, NULL);
> + if (IS_ERR(imx519->xclk)) {
> + dev_err(dev, "failed to get xclk\n");
return dev_err_probe
> + return PTR_ERR(imx519->xclk);
> + }
> +
> + xclk_freq = clk_get_rate(imx519->xclk);
> + if (xclk_freq != IMX519_XCLK_FREQ) {
> + dev_err(dev, "xclk frequency not supported: %d Hz\n",
> + xclk_freq);
return dev_err_probe
> + return -EINVAL;
> + }
> +
> + ret = imx519_get_regulators(imx519);
> + if (ret) {
> + dev_err(dev, "failed to get regulators\n");
> + return ret;
return dev_err_probe
> + }
> +
> + /* Request optional enable pin */
> + imx519->reset_gpio = devm_gpiod_get_optional(dev, "reset",
> + GPIOD_OUT_HIGH);
> +
> + /*
> + * The sensor must be powered for imx519_identify_module()
> + * to be able to read the CHIP_ID register
> + */
> + ret = imx519_power_on(dev);
> + if (ret)
> + return ret;
> +
> + ret = imx519_identify_module(imx519, IMX519_CHIP_ID);
> + if (ret)
> + goto error_power_off;
> +
> + /* Set default mode to max resolution */
> + imx519->mode = &supported_modes_10bit[0];
> + imx519->fmt_code = MEDIA_BUS_FMT_SRGGB10_1X10;
> +
> + /* Enable runtime PM and turn off the device */
> + pm_runtime_set_active(dev);
> + pm_runtime_enable(dev);
> + pm_runtime_idle(dev);
> +
> + /* This needs the pm runtime to be registered. */
> + ret = imx519_init_controls(imx519);
> + if (ret)
> + goto error_power_off;
> +
> + /* Initialize subdev */
> + imx519->sd.internal_ops = &imx519_internal_ops;
> + imx519->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
> + V4L2_SUBDEV_FL_HAS_EVENTS;
> + imx519->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
> +
> + /* Initialize source pads */
> + imx519->pad[IMAGE_PAD].flags = MEDIA_PAD_FL_SOURCE;
> + imx519->pad[METADATA_PAD].flags = MEDIA_PAD_FL_SOURCE;
> +
> + ret = media_entity_pads_init(&imx519->sd.entity, NUM_PADS, imx519->pad);
> + if (ret) {
> + dev_err(dev, "failed to init entity pads: %d\n", ret);
> + goto error_handler_free;
> + }
> +
> + ret = v4l2_async_register_subdev_sensor(&imx519->sd);
> + if (ret < 0) {
> + dev_err(dev, "failed to register sensor sub-device: %d\n", ret);
> + goto error_media_entity;
> + }
> +
> + return 0;
> +
> +error_media_entity:
> + media_entity_cleanup(&imx519->sd.entity);
> +
> +error_handler_free:
> + imx519_free_controls(imx519);
> +
> +error_power_off:
> + pm_runtime_disable(&client->dev);
> + pm_runtime_set_suspended(&client->dev);
> + imx519_power_off(&client->dev);
> +
> + return ret;
> +}
> +
> +static void imx519_remove(struct i2c_client *client)
> +{
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct imx519 *imx519 = to_imx519(sd);
> +
> + v4l2_async_unregister_subdev(sd);
> + media_entity_cleanup(&sd->entity);
> + imx519_free_controls(imx519);
> +
> + pm_runtime_disable(&client->dev);
> + if (!pm_runtime_status_suspended(&client->dev))
> + imx519_power_off(&client->dev);
> + pm_runtime_set_suspended(&client->dev);
> +}
> +
> +MODULE_DEVICE_TABLE(of, imx519_dt_ids);
> +
> +static const struct dev_pm_ops imx519_pm_ops = {
> + SET_SYSTEM_SLEEP_PM_OPS(imx519_suspend, imx519_resume)
> + SET_RUNTIME_PM_OPS(imx519_power_off, imx519_power_on, NULL)
> +};
> +
> +static struct i2c_driver imx519_i2c_driver = {
> + .driver = {
> + .name = "imx519",
> + .of_match_table = imx519_dt_ids,
> + .pm = &imx519_pm_ops,
> + },
> + .probe_new = imx519_probe,
Are you sure? Wasn't i2c already converted?
Best regards,
Krzysztof
Powered by blists - more mailing lists