linux-kernel - [tip: x86/core] x86/smpboot: Remove a stray comment about CPU hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169053248168.28540.18322875262543490504.tip-bot2@tip-bot2>
Date:   Fri, 28 Jul 2023 08:21:21 -0000
From:   "tip-bot2 for Sohil Mehta" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     Sohil Mehta <sohil.mehta@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: [tip: x86/core] x86/smpboot: Remove a stray comment about CPU hotplug

The following commit has been merged into the x86/core branch of tip:

Commit-ID:     52defa4a5e719a57992aed52c8d3e214e75ac276
Gitweb:        https://git.kernel.org/tip/52defa4a5e719a57992aed52c8d3e214e75ac276
Author:        Sohil Mehta <sohil.mehta@...el.com>
AuthorDate:    Thu, 27 Jul 2023 18:05:31 
Committer:     Thomas Gleixner <tglx@...utronix.de>
CommitterDate: Fri, 28 Jul 2023 10:17:53 +02:00

x86/smpboot: Remove a stray comment about CPU hotplug

This old comment is irrelavant to the logic of disabling interrupts and
could be misleading. Remove it.

Now, hlt_play_dead() resembles the code that the comment was initially
added for, but, it doesn't make sense anymore because an offlined cpu
could also be put into other states such as mwait.

Signed-off-by: Sohil Mehta <sohil.mehta@...el.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Link: https://lore.kernel.org/r/20230727180533.3119660-2-sohil.mehta@intel.com

---
 arch/x86/kernel/smpboot.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index e1aa2cd..6a09a02 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1614,9 +1614,7 @@ void play_dead_common(void)
 	idle_task_exit();
 
 	cpuhp_ap_report_dead();
-	/*
-	 * With physical CPU hotplug, we should halt the cpu
-	 */
+
 	local_irq_disable();
 }