[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230728095933.GG8175@google.com>
Date: Fri, 28 Jul 2023 10:59:33 +0100
From: Lee Jones <lee@...nel.org>
To: Benjamin Bara <bbara93@...il.com>
Cc: Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Tony Lindgren <tony@...mide.com>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Dmitry Osipenko <dmitry.osipenko@...labora.com>,
Robin Gong <yibin.gong@....com>,
Jerome Neanne <jneanne@...libre.com>,
linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
linux-omap@...r.kernel.org,
Benjamin Bara <benjamin.bara@...data.com>
Subject: Re: [PATCH 2/6] mfd: rk8xx: Specify restart mode
On Thu, 27 Jul 2023, Benjamin Bara wrote:
> From: Benjamin Bara <benjamin.bara@...data.com>
>
> Specify the implemented restart handler as a cold one.
* The current implementation is an issue because ...
* If this is not fixed, the following will happen ...
* By fixing this in this way and not another way has ... advantages ...
> Signed-off-by: Benjamin Bara <benjamin.bara@...data.com>
> ---
> drivers/mfd/rk8xx-core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/rk8xx-core.c b/drivers/mfd/rk8xx-core.c
> index e8fc9e2ab1d0..15e8e6a9943a 100644
> --- a/drivers/mfd/rk8xx-core.c
> +++ b/drivers/mfd/rk8xx-core.c
> @@ -697,7 +697,8 @@ int rk8xx_probe(struct device *dev, int variant, unsigned int irq, struct regmap
> case RK809_ID:
> case RK817_ID:
> ret = devm_register_sys_off_handler(dev,
> - SYS_OFF_MODE_RESTART, SYS_OFF_PRIO_HIGH,
> + SYS_OFF_MODE_RESTART_COLD,
> + SYS_OFF_PRIO_HIGH,
> &rk808_restart, rk808);
> if (ret)
> dev_warn(dev, "failed to register rst handler, %d\n", ret);
>
> --
> 2.34.1
>
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists