[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87mszgfjai.fsf@nvidia.com>
Date: Fri, 28 Jul 2023 11:30:24 +0200
From: Petr Machata <petrm@...dia.com>
To: Ratheesh Kannoth <rkannoth@...vell.com>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
<pabeni@...hat.com>
Subject: Re: [PATCH v2 net-next] dissector: Use 64bits for used_keys
Ratheesh Kannoth <rkannoth@...vell.com> writes:
> As 32bit of dissector->used_keys are exhausted,
> increase the size to 64bits.
>
> This is base changes for ESP/AH flow dissector patch.
> Please find patch and discussions at
> https://lore.kernel.org/netdev/ZMDNjD46BvZ5zp5I@corigine.com/T/#t
>
> Signed-off-by: Ratheesh Kannoth <rkannoth@...vell.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>
This makes it look like I reviewed the whole thing. I think I wrote
this:
Reviewed-by: Petr Machata <petrm@...dia.com> # for mlxsw
Also, you either missed or ignored my proposal for subject line update.
I do think that "net: flow_dissector:" would be a better prefix, because
that's how the component is called, and it's in the net namespace. It's
OK not to agree, but in that case please argue to that end.
Powered by blists - more mailing lists