linux-kernel - [tip:sched/eevdf 5/12] kernel/sched/fair.c:721:6: sparse: sparse: symbol 'update_entity_lag' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2023 09:44:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        x86@...nel.org, Ingo Molnar <mingo@...nel.org>
Subject: [tip:sched/eevdf 5/12] kernel/sched/fair.c:721:6: sparse: sparse:
 symbol 'update_entity_lag' was not declared. Should it be static?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/eevdf
head:   d07f09a1f99cabbc86bc5c97d962eb8a466106b5
commit: 86bfbb7ce4f67a88df2639198169b685668e7349 [5/12] sched/fair: Add lag based placement
config: i386-randconfig-i061-20230727 (https://download.01.org/0day-ci/archive/20230728/202307280906.nLYx7MtQ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230728/202307280906.nLYx7MtQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307280906.nLYx7MtQ-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> kernel/sched/fair.c:721:6: sparse: sparse: symbol 'update_entity_lag' was not declared. Should it be static?
   kernel/sched/fair.c:1065:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct sched_entity const *se @@     got struct sched_entity [noderef] __rcu * @@
   kernel/sched/fair.c:1065:34: sparse:     expected struct sched_entity const *se
   kernel/sched/fair.c:1065:34: sparse:     got struct sched_entity [noderef] __rcu *
   kernel/sched/fair.c:8167:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *curr @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/fair.c:8167:38: sparse:     expected struct task_struct *curr
   kernel/sched/fair.c:8167:38: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/fair.c:8465:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *curr @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/fair.c:8465:38: sparse:     expected struct task_struct *curr
   kernel/sched/fair.c:8465:38: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/fair.c:6402:35: sparse: sparse: marked inline, but without a definition
   kernel/sched/fair.c: note: in included file:
   kernel/sched/sched.h:2279:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:2279:9: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:2279:9: sparse:    struct task_struct *
   kernel/sched/sched.h:2117:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:2117:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:2117:25: sparse:    struct task_struct *
   kernel/sched/sched.h:2117:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:2117:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:2117:25: sparse:    struct task_struct *

vim +/update_entity_lag +721 kernel/sched/fair.c

   712	
   713	/*
   714	 * Entity is eligible once it received less service than it ought to have,
   715	 * eg. lag >= 0.
   716	 *
   717	 * lag_i = S - s_i = w_i*(V - v_i)
   718	 *
   719	 * lag_i >= 0 -> V >= v_i
   720	 *
 > 721	 *     \Sum (v_i - v)*w_i
   722	 * V = ------------------ + v
   723	 *          \Sum w_i
   724	 *
   725	 * lag_i >= 0 -> \Sum (v_i - v)*w_i >= (v_i - v)*(\Sum w_i)
   726	 *
   727	 * Note: using 'avg_vruntime() > se->vruntime' is inacurate due
   728	 *       to the loss in precision caused by the division.
   729	 */
   730	int entity_eligible(struct cfs_rq *cfs_rq, struct sched_entity *se)
   731	{
   732		struct sched_entity *curr = cfs_rq->curr;
   733		s64 avg = cfs_rq->avg_vruntime;
   734		long load = cfs_rq->avg_load;
   735	
   736		if (curr && curr->on_rq) {
   737			unsigned long weight = scale_load_down(curr->load.weight);
   738	
   739			avg += entity_key(cfs_rq, curr) * weight;
   740			load += weight;
   741		}
   742	
   743		return avg >= entity_key(cfs_rq, se) * load;
   744	}
   745	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki