linux-kernel - Re: [PATCH v3 3/6] ASoC: mediatek: mt7986: add platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db849b742c9d2eeba5db614d672667981402ae94.camel@mediatek.com>
Date:   Fri, 28 Jul 2023 10:13:29 +0000
From:   Maso Huang (黃加竹) 
        <Maso.Huang@...iatek.com>
To:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "chenxiangrui@...qin.corp-partner.google.com" 
        <chenxiangrui@...qin.corp-partner.google.com>,
        Trevor Wu (吳文良) <Trevor.Wu@...iatek.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Allen-KH Cheng (程冠勲) 
        <Allen-KH.Cheng@...iatek.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>, "arnd@...db.de" <arnd@...db.de>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH v3 3/6] ASoC: mediatek: mt7986: add platform driver

On Fri, 2023-07-28 at 11:38 +0200, AngeloGioacchino Del Regno wrote:
> Il 28/07/23 11:08, Maso Huang ha scritto:
> > Add mt7986 platform driver.
> > 
> > Signed-off-by: Maso Huang <maso.huang@...iatek.com>
> > ---
> >   sound/soc/mediatek/Kconfig                 |  10 +
> >   sound/soc/mediatek/Makefile                |   1 +
> >   sound/soc/mediatek/mt7986/Makefile         |   8 +
> >   sound/soc/mediatek/mt7986/mt7986-afe-pcm.c | 622
> > +++++++++++++++++++++
> >   4 files changed, 641 insertions(+)
> >   create mode 100644 sound/soc/mediatek/mt7986/Makefile
> >   create mode 100644 sound/soc/mediatek/mt7986/mt7986-afe-pcm.c
> > 
> 
> ..snip..
> 
> > +	/* register component */
> > +	ret = devm_snd_soc_register_component(&pdev->dev,
> > +					      &mt7986_afe_component,
> > +					      NULL, 0);
> > +	if (ret)
> > +		return dev_err_probe(dev, ret, "err_platform\n");
> 
> I know I only said about using dev_err_probe(), but "err_platform"
> doesn't
> mean anything!
> 
> Please write a human readable error message, like "Cannot register
> AFE component\n"
> 
> > +
> > +	ret = devm_snd_soc_register_component(afe->dev,
> > +					      &mt7986_afe_pcm_dai_compo
> > nent,
> > +					      afe->dai_drivers,
> > +					      afe->num_dai_drivers);
> > +	if (ret)
> > +		return dev_err_probe(dev, ret, "err_dai_component\n");
> 
> And the same here, "Cannot register PCM DAI component\n"
> 
> After which:
> 
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>

Hi Angelo,

Thanks for your review.
I'll refine it with human readable message!

Best regards,
Maso