linux-kernel - Re: [PATCH v5 0/2] soc: loongson2_pm: add power management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230728-unedited-thank-366462ab471d@wendy>
Date:   Fri, 28 Jul 2023 11:18:03 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Huacai Chen <chenhuacai@...nel.org>
CC:     Yinbo Zhu <zhuyinbo@...ngson.cn>, Arnd Bergmann <arnd@...db.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, <linux-pm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Jianmin Lv <lvjianmin@...ngson.cn>,
        <wanghongliang@...ngson.cn>, Liu Peibao <liupeibao@...ngson.cn>,
        <loongson-kernel@...ts.loongnix.cn>, Liu Yun <liuyun@...ngson.cn>,
        <kernel@...0n.name>
Subject: Re: [PATCH v5 0/2] soc: loongson2_pm: add power management support

On Fri, Jul 28, 2023 at 05:48:29PM +0800, Huacai Chen wrote:
> On Fri, Jul 28, 2023 at 4:44 PM Conor Dooley <conor.dooley@...rochip.com> wrote:
> > On Fri, Jul 28, 2023 at 03:49:42PM +0800, Yinbo Zhu wrote:
> > > Loongson-2 platform support Power Management Controller (ACPI) and this
> > > series patch was to add PM driver that base on dts and PM binding support.
> > >
> > > Change in v5:
> > >               1. The patch "[PATCH v3 1/3] loongarch: export some arch-specific
> > >                  pm interfaces" had been merged into linux-next tree thus this
> > >                  v4 series patch need drop it and need depend on it and it's
> > >                  patch link was:
> > > https://lore.kernel.org/all/20230615091757.24686-2-zhuyinbo@loongson.cn/
> >
> > Just to note, it might be in linux-next, but more importantly it is also
> > in v6.5-rc1, so there is no issue with dependencies.
> >
> > >               2. Swap the positions of compatible for 2k1000 and 2k0500.
> >
> > I noticed you sent a mail pinging the v4 of this series yesterday as it
> > had not been picked up. Who do you actually expect to apply these
> > patches? There does not appear to be a maintainer listed for the
> > drivers/soc/loongson directory, just one for your GUTS driver.
> >
> > As a result, patches like
> > <https://lore.kernel.org/all/a69170cb55cfc73e378b40ccf1d9c16f@208suo.com/>
> > have gone ignored. Granted, that patch is probably crap that does not
> > apply, due to 208suo.com people sending corrupted patches, but you the
> > point.
> >
> > More interestingly there is also
> > <https://lore.kernel.org/all/40b324af-3483-4b3d-b65a-a97944aa4a70@app.fastmail.com/>
> > which seems to have also gone missing (I don't see it in linux-next),
> > despite some discussion about how the patch should be merged.
> >
> > Looks to me like drivers/soc/loongson/ needs someone to take
> > responsibility for picking up patches for the directory & sending them
> > to the soc maintainers (with a new MAINTAINERS entry reflecting that) so
> > that patches don't fall through the cracks.

> As discussed when the guts driver gets merged, I think it is better to
> go via Arnd's soc tree for these patches under drivers/soc/loongson/.

Discussed perhaps, and that does seem to me like the correct thing to do,
but nobody actually did anything about it.
Somebody needs to set up a git tree, add a MAINTAINERS entry for the
directory, actually apply the patches and then send a PR to the soc
maintainers (as mentioned by Arnd in the second patch I linked there).

Perhaps that someone is you, or maybe it is Yinbo, up to you guys to
decide :)

Cheers,
Conor.


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)