[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ebfc016f57ec50ea8026efdce575813a75676b5c.camel@mediatek.com>
Date: Fri, 28 Jul 2023 10:16:21 +0000
From: Maso Huang (黃加竹)
<Maso.Huang@...iatek.com>
To: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"chenxiangrui@...qin.corp-partner.google.com"
<chenxiangrui@...qin.corp-partner.google.com>,
Trevor Wu (吳文良) <Trevor.Wu@...iatek.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
Allen-KH Cheng (程冠勲)
<Allen-KH.Cheng@...iatek.com>,
"broonie@...nel.org" <broonie@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
"tiwai@...e.com" <tiwai@...e.com>,
"lgirdwood@...il.com" <lgirdwood@...il.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"perex@...ex.cz" <perex@...ex.cz>, "arnd@...db.de" <arnd@...db.de>,
"angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH v3 5/6] ASoC: dt-bindings: mediatek,mt7986-wm8960: add
mt7986-wm8960 document
On Fri, 2023-07-28 at 11:55 +0200, AngeloGioacchino Del Regno wrote:
> Il 28/07/23 11:08, Maso Huang ha scritto:
> > Add document for mt7986 board with wm8960.
> >
> > Signed-off-by: Maso Huang <maso.huang@...iatek.com>
> > ---
> > .../sound/mediatek,mt7986-wm8960.yaml | 53
> > +++++++++++++++++++
> > 1 file changed, 53 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/sound/mediatek,mt7986-
> > wm8960.yaml
> > b/Documentation/devicetree/bindings/sound/mediatek,mt7986-
> > wm8960.yaml
> > new file mode 100644
> > index 000000000000..76394f7e5502
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt7986-
> > wm8960.yaml
> > @@ -0,0 +1,53 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mediatek,mt7986-wm8960.yaml*__;Iw!!CTRNKA9wMg0ARbw!lu4Z6pJeRiL7-8l4T3ptqUCM54FnHTBiyh5KWBNqSjl6mOOI7WmzHpWEd-ZSZ-2NJ4Cs9PPaAF_75ywo2SKW16MPPRaROt0$
> >
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!lu4Z6pJeRiL7-8l4T3ptqUCM54FnHTBiyh5KWBNqSjl6mOOI7WmzHpWEd-ZSZ-2NJ4Cs9PPaAF_75ywo2SKW16MPttZILAo$
> >
> > +
> > +title: MediaTek MT7986 sound card with WM8960 codec
> > +
> > +maintainers:
> > + - Maso Huang <maso.huang@...iatek.com>
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt7986-wm8960-machine
>
> mediatek,mt7986-wm8960-sound looks better.
>
> After which,
>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>
>
>
Hi Angelo,
Thanks for your review.
I'll change the compatible to "mediatek,mt7986-wm8960-sound" in v4
patch.
Best regards,
Maso
Powered by blists - more mailing lists