linux-kernel - Re: [PATCH v3 42/50] irqchip/atmel-aic5: Add support for sam9x7 aic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ee1e3c365686bc60e92ba3972dc1a5@kernel.org>
Date:   Fri, 28 Jul 2023 11:37:48 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Varshini Rajendran <varshini.rajendran@...rochip.com>
Cc:     tglx@...utronix.de, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, claudiu.beznea@...rochip.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Hari Prasath <Hari.PrasathGE@...rochip.com>
Subject: Re: [PATCH v3 42/50] irqchip/atmel-aic5: Add support for sam9x7 aic

On 2023-07-28 11:30, Varshini Rajendran wrote:
> From: Hari Prasath <Hari.PrasathGE@...rochip.com>
> 
> Add support for the Advanced interrupt controller(AIC) chip in the 
> sam9x7.
> 
> Signed-off-by: Hari Prasath <Hari.PrasathGE@...rochip.com>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> ---
>  drivers/irqchip/irq-atmel-aic5.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/irqchip/irq-atmel-aic5.c 
> b/drivers/irqchip/irq-atmel-aic5.c
> index 145535bd7560..bab11900f3ef 100644
> --- a/drivers/irqchip/irq-atmel-aic5.c
> +++ b/drivers/irqchip/irq-atmel-aic5.c
> @@ -320,6 +320,7 @@ static const struct of_device_id aic5_irq_fixups[]
> __initconst = {
>  	{ .compatible = "atmel,sama5d3", .data = sama5d3_aic_irq_fixup },
>  	{ .compatible = "atmel,sama5d4", .data = sama5d3_aic_irq_fixup },
>  	{ .compatible = "microchip,sam9x60", .data = sam9x60_aic_irq_fixup },
> +	{ .compatible = "microchip,sam9x7", .data = sam9x60_aic_irq_fixup },
>  	{ /* sentinel */ },
>  };
> 
> @@ -406,3 +407,12 @@ static int __init sam9x60_aic5_of_init(struct
> device_node *node,
>  	return aic5_of_init(node, parent, NR_SAM9X60_IRQS);
>  }
>  IRQCHIP_DECLARE(sam9x60_aic5, "microchip,sam9x60-aic", 
> sam9x60_aic5_of_init);
> +
> +#define NR_SAM9X7_IRQS		70

One can only wonder why this stuff doesn't come from the device tree,
given that there is no other meaningful difference between this
version of the IP and the previous ones...

         M.

> +
> +static int __init sam9x7_aic5_of_init(struct device_node *node,
> +				      struct device_node *parent)
> +{
> +	return aic5_of_init(node, parent, NR_SAM9X7_IRQS);
> +}
> +IRQCHIP_DECLARE(sam9x7_aic5, "microchip,sam9x7-aic", 
> sam9x7_aic5_of_init);

-- 
Jazz is not dead. It just smells funny...