linux-kernel - Re: [PATCH v3 13/50] dt-bindings: i2c: at91: Add sam9x7 compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02c907b9-9c86-9f97-35c1-70e9ed041cdb@linaro.org>
Date:   Fri, 28 Jul 2023 13:53:07 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Varshini Rajendran <varshini.rajendran@...rochip.com>,
        andi.shyti@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
        claudiu.beznea@...rochip.com, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 13/50] dt-bindings: i2c: at91: Add sam9x7 compatible
 string

On 28/07/2023 12:25, Varshini Rajendran wrote:
> Add compatible string for sam9x7.
> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> ---
>  Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml b/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml
> index 6adedd3ec399..6f3158604d02 100644
> --- a/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml
> @@ -27,6 +27,9 @@ properties:
>        - items:
>            - const: microchip,sama7g5-i2c
>            - const: microchip,sam9x60-i2c
> +      - items:
> +          - const: microchip,sam9x7-i2c

Make it an enum with sama7g5.

> +          - const: microchip,sam9x60-i2c
>  
>    reg:
>      maxItems: 1
> @@ -84,6 +87,7 @@ allOf:
>                - atmel,sama5d4-i2c
>                - atmel,sama5d2-i2c
>                - microchip,sam9x60-i2c
> +              - microchip,sam9x7-i2c

This shouldn't be needed.

>                - microchip,sama7g5-i2c
>      then:
>        properties:

Best regards,
Krzysztof