[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <17c2ba50-3b72-523c-d92b-1ecbf9be7450@linaro.org>
Date: Fri, 28 Jul 2023 14:03:17 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Krishna chaitanya chundru <quic_krichai@...cinc.com>,
manivannan.sadhasivam@...aro.org
Cc: helgaas@...nel.org, linux-pci@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
quic_vbadigan@...cinc.com, quic_nitegupt@...cinc.com,
quic_skananth@...cinc.com, quic_ramkri@...cinc.com,
quic_parass@...cinc.com,
"reviewer:ARM/QUALCOMM CHROMEBOOK SUPPORT"
<cros-qcom-dts-watchers@...omium.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>
Subject: Re: [PATCH v1] arm64: dts: qcom: sc7280: Add PCIe0 node
On 28/07/2023 12:39, Krishna chaitanya chundru wrote:
> Add PCIe dtsi node for PCIe0 controller on sc7280 platform.
>
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@...cinc.com>
Thank you for your patch. There is something to discuss/improve.
> + pcie0_phy: phy@...6000 {
> + compatible = "qcom,sm8250-qmp-gen3x1-pcie-phy";
> + reg = <0 0x01c06000 0 0x1c0>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> + clocks = <&gcc GCC_PCIE_0_AUX_CLK>,
> + <&gcc GCC_PCIE_0_CFG_AHB_CLK>,
> + <&gcc GCC_PCIE_CLKREF_EN>,
> + <&gcc GCC_PCIE0_PHY_RCHNG_CLK>;
> + clock-names = "aux", "cfg_ahb", "ref", "refgen";
> +
> + resets = <&gcc GCC_PCIE_0_PHY_BCR>;
> + reset-names = "phy";
> +
> + assigned-clocks = <&gcc GCC_PCIE0_PHY_RCHNG_CLK>;
> + assigned-clock-rates = <100000000>;
> +
> + status = "disabled";
> +
> + pcie0_lane: phy@...e6200 {
Isn't this old-style of bindings? Wasn't there a change? On what tree
did you base it?
> +
> + pcie0_wake_n: pcie0-wake-n {
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Nodes end with 'state'.
> + pins = "gpio89";
> + function = "gpio";
> +
> + drive-strength = <2>;
> + bias-pull-up;
> + };
Best regards,
Krzysztof
Powered by blists - more mailing lists