linux-kernel - Re: [PATCH v2 10/22] i2c: kempld: Convert to use regular device PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230728121915.vv2sszyiz5vwuhqg@intel.intel>
Date:   Fri, 28 Jul 2023 14:19:15 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 10/22] i2c: kempld: Convert to use regular device PM

Hi Paul,

On Sat, Jul 22, 2023 at 01:50:34PM +0200, Paul Cercueil wrote:
> Provide PM callbacks through platform_driver.driver.pm instead of
> platform_driver.{suspend,resume} as any good-behaved driver should do.
> 
> Use the new PM macros for the suspend and resume functions to be
> automatically dropped by the compiler when CONFIG_PM or
> CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
> 
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>

Acked-by: Andi Shyti <andi.shyti@...nel.org> 

Thanks,
Andi