linux-kernel - Re: [PATCH v3 28/50] dt-bindings: watchdog: sama5d4-wdt: add compatible for sam9x7-wdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfd3d138-5cfa-1ee3-f578-1f2452900f9f@linaro.org>
Date:   Fri, 28 Jul 2023 14:39:39 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Varshini Rajendran <varshini.rajendran@...rochip.com>,
        wim@...ux-watchdog.org, linux@...ck-us.net, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
        claudiu.beznea@...rochip.com, eugen.hristev@...labora.com,
        linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 28/50] dt-bindings: watchdog: sama5d4-wdt: add
 compatible for sam9x7-wdt

On 28/07/2023 12:28, Varshini Rajendran wrote:
> Add compatible microchip,sam9x7-wdt to DT bindings documentation.
> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> ---
>  .../bindings/watchdog/atmel,sama5d4-wdt.yaml      | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> index 816f85ee2c77..ce3d046e7244 100644
> --- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> @@ -14,10 +14,17 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum:
> -      - atmel,sama5d4-wdt
> -      - microchip,sam9x60-wdt
> -      - microchip,sama7g5-wdt
> +    oneOf:
> +      - items:

Drop items.

> +          - enum:
> +              - atmel,sama5d4-wdt
> +              - microchip,sam9x60-wdt
> +              - microchip,sama7g5-wdt
> +      - items:
> +          - enum:
> +              - microchip,sam9x7-wdt
> +          - enum:

Not an enum.

It is surprising how the same change look different between two of your
patches.


Best regards,
Krzysztof