linux-kernel - Re: [PATCH v4 07/11] firmware: qcom_scm: ipq5332: add msa lock/unlock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230729003037.GA25463@quicinc.com>
Date:   Fri, 28 Jul 2023 17:30:37 -0700
From:   Guru Das Srinagesh <quic_gurus@...cinc.com>
To:     Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
CC:     <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <mathieu.poirier@...aro.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>, <mturquette@...libre.com>,
        <sboyd@...nel.org>, <quic_eberman@...cinc.com>, <kvalo@...nel.org>,
        <loic.poulain@...aro.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <quic_srichara@...cinc.com>, <quic_sjaganat@...cinc.com>,
        <quic_kathirav@...cinc.com>, <quic_anusha@...cinc.com>,
        <quic_varada@...cinc.com>
Subject: Re: [PATCH v4 07/11] firmware: qcom_scm: ipq5332: add msa
 lock/unlock support

On Jul 28 2023 12:04, Manikanta Mylavarapu wrote:
> IPQ5332 user pd remoteproc firmwares need to be locked
> with MSA(modem secure access) features. This patch add
> support to lock/unlock MSA features.
> 
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
> ---
> Changes in v4:
> 	- Rebased on linux-next
> 
>  drivers/firmware/qcom_scm.c            | 78 ++++++++++++++++++++++++++
>  drivers/firmware/qcom_scm.h            |  2 +
>  include/linux/firmware/qcom/qcom_scm.h |  2 +
>  3 files changed, 82 insertions(+)
> 
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 3bc8c63a997f..2275cf7bc887 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -676,6 +676,84 @@ bool qcom_scm_pas_supported(u32 peripheral)
>  }
>  EXPORT_SYMBOL(qcom_scm_pas_supported);
>  
> +/**
> + * qcom_scm_msa_lock() - Lock given peripheral firmware region as MSA
> + *
> + * @peripheral:	peripheral id
> + *
> + * Return 0 on success.
> + */
> +int qcom_scm_msa_lock(u32 peripheral)
> +{
> +	int ret;
> +	struct qcom_scm_desc desc = {
> +		.svc = QCOM_SCM_SVC_PIL,
> +		.cmd = QCOM_SCM_MSA_LOCK,
> +		.arginfo = QCOM_SCM_ARGS(1),
> +		.args[0] = peripheral,
> +		.owner = ARM_SMCCC_OWNER_SIP,
> +	};
> +	struct qcom_scm_res res;
> +
> +	if (!__qcom_scm_is_call_available(__scm->dev, QCOM_SCM_SVC_PIL,
> +					  QCOM_SCM_MSA_LOCK))
> +		return 0;
> +
> +	ret = qcom_scm_clk_enable();
> +	if (ret)
> +		return ret;
> +
> +	ret = qcom_scm_bw_enable();
> +	if (ret)
> +		return ret;
> +
> +	ret = qcom_scm_call(__scm->dev, &desc, &res);
> +	qcom_scm_bw_disable();
> +	qcom_scm_clk_disable();
> +
> +	return ret ? : res.result[0];
> +}
> +EXPORT_SYMBOL(qcom_scm_msa_lock);

Could you please convert this to EXPORT_SYMBOL_GPL? 

> +
> +/**
> + * qcom_scm_msa_unlock() - Unlock given peripheral MSA firmware region
> + *
> + * @peripheral:	peripheral id
> + *
> + * Return 0 on success.
> + */
> +int qcom_scm_msa_unlock(u32 peripheral)
> +{
> +	int ret;
> +	struct qcom_scm_desc desc = {
> +		.svc = QCOM_SCM_SVC_PIL,
> +		.cmd = QCOM_SCM_MSA_UNLOCK,
> +		.arginfo = QCOM_SCM_ARGS(1),
> +		.args[0] = peripheral,
> +		.owner = ARM_SMCCC_OWNER_SIP,
> +	};
> +	struct qcom_scm_res res;
> +
> +	if (!__qcom_scm_is_call_available(__scm->dev, QCOM_SCM_SVC_PIL,
> +					  QCOM_SCM_MSA_UNLOCK))
> +		return 0;
> +
> +	ret = qcom_scm_clk_enable();
> +	if (ret)
> +		return ret;
> +
> +	ret = qcom_scm_bw_enable();
> +	if (ret)
> +		return ret;
> +
> +	ret = qcom_scm_call(__scm->dev, &desc, &res);
> +	qcom_scm_bw_disable();
> +	qcom_scm_clk_disable();
> +
> +	return ret ? : res.result[0];
> +}
> +EXPORT_SYMBOL(qcom_scm_msa_unlock);

This one too?

Reference: [1]
The whole driver has now moved to using EXPORT_SYMBOL_GPL() now.

[1] https://lore.kernel.org/lkml/19d9ac0bf79f957574ef9b3b73246ea0113cc0fd.1690503893.git.quic_gurus@quicinc.com/

Thank you.

Guru Das.