linux-kernel - Re: [PATCH 6/6] scsi: mpt3sas: Replace a dynamic allocation with a local variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZMTPQ9c0hmVBapxe@equiv.tech>
Date:   Sat, 29 Jul 2023 01:35:15 -0700
From:   James Seo <james@...iv.tech>
To:     Kees Cook <keescook@...omium.org>
Cc:     Sathya Prakash <sathya.prakash@...adcom.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        MPT-FusionLinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] scsi: mpt3sas: Replace a dynamic allocation with a
 local variable

On Fri, Jul 28, 2023 at 03:29:17PM -0700, Kees Cook wrote:
> On Tue, Jul 25, 2023 at 09:13:31AM -0700, James Seo wrote:
>> This dynamic allocation can be replaced with a local variable.
>> 
>> Signed-off-by: James Seo <james@...iv.tech>
>> ---
>>  drivers/scsi/mpt3sas/mpt3sas_base.c | 19 +++++--------------
>>  1 file changed, 5 insertions(+), 14 deletions(-)
>> 
>> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
>> index cd6f36094159..a32a6fa728a7 100644
>> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
>> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
>> @@ -5361,10 +5361,9 @@ _base_update_diag_trigger_pages(struct MPT3SAS_ADAPTER *ioc)
>>  static int _base_assign_fw_reported_qd(struct MPT3SAS_ADAPTER *ioc)
>>  {
>>  	Mpi2ConfigReply_t mpi_reply;
>> -	Mpi2SasIOUnitPage1_t *sas_iounit_pg1 = NULL;
>> +	Mpi2SasIOUnitPage1_t sas_iounit_pg1;
>>  	Mpi26PCIeIOUnitPage1_t pcie_iounit_pg1;
>>  	u16 depth;
>> -	int sz;
>>  	int rc = 0;
>>  
>>  	ioc->max_wideport_qd = MPT3SAS_SAS_QUEUE_DEPTH;
>> @@ -5374,28 +5373,21 @@ static int _base_assign_fw_reported_qd(struct MPT3SAS_ADAPTER *ioc)
>>  	if (!ioc->is_gen35_ioc)
>>  		goto out;
>>  	/* sas iounit page 1 */
>> -	sz = offsetof(Mpi2SasIOUnitPage1_t, PhyData);
>> -	sas_iounit_pg1 = kzalloc(sizeof(Mpi2SasIOUnitPage1_t), GFP_KERNEL);
> 
> Hunh. So Mpi2SasIOUnitPage1_t is used without the flexarray at all?
> 
> -Kees

You call it "dead code" and "unused struct members".
mpt3sas evidently calls it "documentation" ;)

Anyway, does this commit get your "Reviewed-by:"?

James