linux-kernel - RE: [PATCH] mmc: core: propagate removable attribute to driver core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR04MB657588B4D59F500881051B38FC07A@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Sat, 29 Jul 2023 12:28:28 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Thomas Weißschuh <linux@...ssschuh.net>,
        Ulf Hansson <ulf.hansson@...aro.org>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@....de>
Subject: RE: [PATCH] mmc: core: propagate removable attribute to driver core

> 
> Userspace can use this to distinguish hotpluggable mmc devices such as
> sdcards from non-hotpluggable ones such as eMMC.
> One example is the lsblk tool from util-linux.
> 
> Note that dev_set_removable() is not related to GENHD_FL_REMOVABLE
> which
> is not applicable as per the comment in drivers/mmc/core/block.c
> 
> Link: https://github.com/util-linux/util-linux/issues/2379
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
Reviewed-by: Avri Altman <avri.altman@....com>

> ---
>  drivers/mmc/core/bus.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
> index 2c3074a605fc..0af96548e7da 100644
> --- a/drivers/mmc/core/bus.c
> +++ b/drivers/mmc/core/bus.c
> @@ -310,6 +310,9 @@ int mmc_add_card(struct mmc_card *card)
> 
> 
>         dev_set_name(&card->dev, "%s:%04x", mmc_hostname(card->host),
> card->rca);
> +       dev_set_removable(&card->dev,
> +                         mmc_card_is_removable(card->host) ?
> +                         DEVICE_REMOVABLE : DEVICE_FIXED);
> 
>         switch (card->type) {
>         case MMC_TYPE_MMC:
> 
> ---
> base-commit: 0b5547c51827e053cc754db47d3ec3e6c2c451d2
> change-id: 20230725-mmc-removable-5cfdca9ed062
> 
> Best regards,
> --
> Thomas Weißschuh <linux@...ssschuh.net>