[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMRc=MfEtGRk4A4YDgGvd2Fsv8GtH02kAix57TaFcbcDk0HEZw@mail.gmail.com>
Date: Sat, 29 Jul 2023 16:05:01 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Andrei Coardos <aboutphysycs@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
andy@...nel.org, linus.walleij@...aro.org,
Alexandru Ardelean <alex@...uggie.ro>
Subject: Re: [PATCH] gpio: exar: remove unneeded platform_set_drvdata() call
On Wed, Jul 19, 2023 at 11:41 AM Andrei Coardos <aboutphysycs@...il.com> wrote:
>
> The platform_set_drvdata() was needed when the driver had an explicit
> remove function.
> That function got removed a while back, so we don't need to keep a pointer
> (on 'dev->driver_data') for the private data of the driver anymore.
>
> Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
> drivers/gpio/gpio-exar.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c
> index df1bdaae441c..5170fe7599cd 100644
> --- a/drivers/gpio/gpio-exar.c
> +++ b/drivers/gpio/gpio-exar.c
> @@ -217,8 +217,6 @@ static int gpio_exar_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - platform_set_drvdata(pdev, exar_gpio);
> -
> return 0;
> }
>
> --
> 2.34.1
>
Applied, thanks!
Bart
Powered by blists - more mailing lists