linux-kernel - Re: [PATCH] gpio: logicvc: remove unneeded platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mfvfj1VgRkJUbcnqHr=RM1oaR4+nDGX46FLyE_pfhX0UA@mail.gmail.com>
Date:   Sat, 29 Jul 2023 16:06:13 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        andy@...nel.org, linus.walleij@...aro.org,
        Alexandru Ardelean <alex@...uggie.ro>
Subject: Re: [PATCH] gpio: logicvc: remove unneeded platform_set_drvdata() call

On Wed, Jul 19, 2023 at 11:48 AM Andrei Coardos <aboutphysycs@...il.com> wrote:
>
> The platform_set_drvdata() isn't needed for anything. The function is a
> simple setter that doesn't change anything in the code. That is because
> there isn't a get function and since it has no dependencies it can be
> removed.
>
> Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
>  drivers/gpio/gpio-logicvc.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-logicvc.c b/drivers/gpio/gpio-logicvc.c
> index 992cc958a43f..9b4789deae45 100644
> --- a/drivers/gpio/gpio-logicvc.c
> +++ b/drivers/gpio/gpio-logicvc.c
> @@ -139,8 +139,6 @@ static int logicvc_gpio_probe(struct platform_device *pdev)
>         logicvc->chip.set = logicvc_gpio_set;
>         logicvc->chip.direction_output = logicvc_gpio_direction_output;
>
> -       platform_set_drvdata(pdev, logicvc);
> -
>         return devm_gpiochip_add_data(dev, &logicvc->chip, logicvc);
>  }
>
> --
> 2.34.1
>

Applied, thanks!

Bart