linux-kernel - Re: [PATCH] mips: dts: ralink: reorder MT7621 clocks in Ethernet block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 29 Jul 2023 17:08:55 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Rafał Miłecki <zajec5@...il.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH] mips: dts: ralink: reorder MT7621 clocks in Ethernet
 block

On 29.07.2023 14:04, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
> 
> Use order as specified in the binding (first "ethif" then "fe").
> 
> This fixes:
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@...00000: clock-names:0: 'ethif' was expected
>          From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@...00000: clock-names:1: 'fe' was expected
>          From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
> 
> Fixes: 7a6ee0bbab25 ("mips: dts: ralink: add MT7621 SoC")
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>

I'm not sure if I should agree with this patch. The relevant parts of 
the schema for mediatek,mt7621-eth were added way later than the 
existing bindings on mt7621.dtsi. Why don't we address this on the 
schema along with a bunch of other issues the patch for 
mediatek,mt7621-eth brought?

Arınç